User:Mont29/Foundation/2021

Weekly Reports for Year 2021

Week 412 - 06/05 to 06/11

Week 411 - 05/29 to 06/04

Week 410 - 05/22 to 05/28

Week 409 - 05/15 to 05/21

Week 408 - 05/08 to 05/14

Week 407 - 05/01 to 05/07

Week 406 - 04/24 to 04/30

Week 405 - 04/17 to 04/23

Week 404 - 04/10 to 04/16

Week 403 - 04/03 to 04/09

Shorter week, spent on finishing initial patch for the depsgraph issue, and some more fixing to liboverrides issues reported by the studio.

Next week: time off.

  • Misc:
    • Finalized and committed Override view for the Outliner (D10855, rB8b68a758, rBe1ae5bd4).
    • Outliner: Added more item types to the ‘compact single icon’ view when parent item is folded (D10855, rB92dfc8f2).
    • Created counter-proposition to D10332: Fix const-correctness in ID preview code (D10922).
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Code quality: Use ID-type callback to get an ID's preview-image (D10332).
    • Investigated T85752 Collection Instance Crash when instancing collections with disabled subcollections (D10907).
    • LibOverride: Fixed (auto-)resync easily creating a lot of unwanted instantiations of override objects and collections in the view layer (rBe92a7800).
    • LibOverride: Fixed (auto-)resync generating broken results in some cases when resyncing recursive overrides (rBed5507de).
    • LibOverride: Fixed (unreported) assert when creating overrides of linked overrides (rB3bd892a7).
Fixed (studio reported): 2; Unreported Fixes: 1; Investigated: 1; Reviewed: 1; Closed: 1;

Week 402 - 03/27 to 04/02

Not the most productive week, spent essentially on one issue regarding depsgraph evaluation and skipped data-blocks.

Next week: Back to overrides.

  • Misc:
    • LibOverride: Work on Outliner view.
    • LibOverride: Fixes for new (auto-)resync behavior for the studio.
    • Updated i18n translations.
    • Meetings.
    • Catch up on mobile station (back to France).
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Investigated T85752 Collection Instance Crash when instancing collections with disabled subcollections.
Investigated: 1;

Week 401 - 03/20 to 03/26

Week spent again mainly on fixing and polishing the new resync process (and other parts of liboverrides), and work on the new Outliner view for those.

Next week: Probably the same.

  • Misc:
    • LibOverride: Work on Outliner view.
    • LibOverride: Fixes for new (auto-)resync behavior for the studio.
    • ID management: tweak order of ID types processing (also fixes minor glitches with liboverride auto-resync process) (from rB4d18fa26 to rB8bbd6ba8).
    • Updated i18n translations.
    • Meetings.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Skip undo steps when changing properties of the 3d cursor through the UI (D10695).
    • Reviewed Overrides: API to create an override template (D10792).
    • Reviewed Fix: Cryptomatte Metadata Trimmed to 1024 (D10825).
    • Fixed T86405 Add-ons not translated to English (rB7a05ebf8).
    • Fixed T86741 Overrides: Collection can be made to appear twice in the outliner (rBe3f2c94d).
    • Fixed T86853 Corrupted Blend file with overridden MeshSequenceCache (rB150e0553).
    • Fixed (unreported) memleak in collection/viewlayer code (rB56dabfac).
    • Fixed (unreported) Outliner: missing override tree items for collections in Viewlayer view (rBa6664383).
    • Fixed (unreported) broken compilation after recent GPencil commit (rBd0d0d9d7).
Fixed: 3; Unreported Fixes: 3; Reviewed: 3; Closed: 1;

Week 400 - 03/13 to 03/19

Week spent again mainly on fixing and polishing the new resync process for liboverrides, and work on the new Outliner view for those.

Next week: Probably the same.

  • Misc:
    • LibOverride: Work on Outliner view.
    • LibOverride: Fixes and polishing for new (auto-)resync behavior for the studio.
    • Updated i18n translations.
    • Meetings.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed LibraryOverrides: Update Python API (D10747).
    • Reviewed BLO: Functions for temporarily loading a single datablock (D10736).
    • Reviewed Automated testing: selection operators test cases (D10400).
    • Fixed T86609 Red brush width circle around cursor disappears after undo in Grease Pencil Sculpt Mode (rBe6bdd571).
    • Fixed T56594 Overrides: Possible collection "duplication" (rB248d9809).
Fixed: 2; Reviewed: 3; Closed: 2;

Week 399 - 03/06 to 03/12

Week spent again mainly on committing and polishing the new resync process for liboverrides, and work on the new Outliner view for those.

Next week: Moar aftermath for resync, and outliner view improvements.

  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Fix T86210: No preview icons for non-8bit images (D10601).
    • Reviewed Fix T86431: Keep the memory location of the window manager when loading a file (D10690).
    • Reviewed Fix heap buffer overflow appending/linking from a blend file (D10703).
    • Reviewed Library Overrides: Manual (D10642).
Fixed: 0; Reviewed: 4; Closed: 1;

Week 398 - 02/27 to 03/05

Week spent almost exclusively on finishing the new resync process for liboverrides.

Next week: Overrides project (aftermath for resync, and mainly outliner view improvements).

  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Fixed T86028 Crash trying to load file with a missing library on line fd->library_file_missing_count++; (rBaad2f1510a80 rBaad2f151).
    • Fixed T86087 Assert when changing compositor node value or invoking tooltip (rBca63729a).
    • Fixed T85981 Undo on linked rig with overrides loses custom shapes (rB4cc04beb).
    • Fixed T85981 part II: bone's custom shape disappear on undo in some cases (rBb3005bf6).
    • Fixed T86209 Preference Defaults "Relative Paths" tooltip could be improved (rBbda95ac0, rBM7806rBM).
    • Fixed (unreported) broken OCIO from install_deps (rB28f0a4b2).
    • Worked around T86015 Crash undoing in certain scenario (disabling Global Undo) (rB9def00a8).
Fixed: 6; Unreported fixes: 1; Closed: 2;

Week 397 - 02/20 to 02/26

Week spent on quiet a few side-tracked time sinks, and various small improvements for linking and data-management (based on feedback from the studio).

Next week: Overrides project.

  • Misc:
    • Improved the ‘purge’ operation on unused IDs, to support recursive deletion of indirectly unused IDs as well (rBb958a59c, rBec4d412c, rB2718ea80).
      • Various other fixes/cleanups/refactors related to this task (rBde25b79f).
    • Some more install_deps lib updates for 2.93.
    • Reworked error/warning reporting when loading missing linked data, to only generate one message in the UI (rB53d13b6f).
    • Various minor dev and meetings regarding overrides project.
    • Updated i18n translations.
      • Had to fight with some python/bpy regressions (see TT85872).
      • Then had to fight with usage of unicode escape sequences in UI messages defined in ‘raw’ C code (see rB32073993)...
    • Meetings.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Investigated T85807 Curve with bevel radius appears black after using Redo Panel (undo issue).
    • Fixed T85947 objects from appended scenes are added to current scene as well (if they are directly under the Scene Collection in the source file) (rB8f6fd07b).
    • Fixed (unreported) bad usercount handling in batch ID deletion (rB1df6cd67).
Fixed: 1; Unreported fixes: 1; Investigated: 1; Closed: 1;

Week 396 - 02/13 to 02/19

Again quiet a few meetings, besides that week was spent on almost only two tasks: some schemas for general concepts behind overrides, and... the usual undo rabbit hole of Hell.

Next week: Overrides project.

  • Misc:
    • LibOverride: design work for the insertion/re-ordering of items in RNA collections (TT82160).
    • LibOverride: high-level design documentation.
    • Undo system: on-going refactor work to sanitize and clarify our undo code (T83806, T85797, D10475).
    • Management work in phabricator (follow-up to modules changes).
    • Updated i18n translations.
    • Meetings.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
Fixed: 0; Reviewed: 0; Closed: 0;

Week 395 - 02/06 to 02/12

Many meetings, also some time spent on non-Blender topics. Otherwise, enhancing overrides' resync process, and finishing the work on updating libraries for 2.93.

Next week: Overrides project, hopefully some time to work on undo issues too.

  • Misc:
    • 2.93 release: Finished updating install_deps for new libs (T85365).
    • LibOverrides: Various minor fixes/improvements to resync code.
    • Updated i18n translations.
    • Meetings.
    • Network issues investigations with sysadmin.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Fix T71960: Malformed .bmp files lead to crash (D10357).
    • Reviewed Assets/IDs: Don't generate previews for object types with no real geometry (D10334).
    • Reviewed Code quality: Use ID-type callback to get an ID's preview-image (D10332).
    • Reviewed Cleanup: delete comments with test index (D10277).
    • Reviewed Mesh automated testing: improve progress printing (D10278).
    • Reviewed Mesh automated testing: compare selection (D10279).
    • Reviewed install_deps: Update OpenXR repository info (D10373).
    • Reviewed PyAPI: Use PyPreConfig & PyConfig for Python initialization (D10382).
    • Reviewed Mesh automated testing: compare selection (D10279).
    • Reviewed Proposal to change behavior when the active object is hidden (T85532).
    • Fixed (studio-reported) crash in readfile code (D10307, rB302625eb.
    • Fixed (unreported) finding system Haru library on Debian (rB847da617).
Fixed: 1; unreported Fix: 1; Reviewed: 10; Closed: 0;

Week 394 - 01/30 to 02/05

Again quiet a few meetings, enhancing overrides' resync process, and also some work on updating libraries for 2.93.

Next week: Overrides project, more libraries update.

  • Misc:
    • Work on enhancements/fixes to LibOverride resync process (T83811).
    • LibOverrides: fixed/improved further resync process (rB95703d19, rB7d5640ee).
    • Python API: Added option to filter out non-asset IDs in input list generated by bpy.libraries.load (D10237, rB48841538).
    • Undo system: on-going refactor work to sanitize and clarify our undo code (T83806, D10227, rBc9d6737e).
    • 2.93 release: Created global lib updates task (T85365).
    • 2.93 release: Updated some libraries on install_deps.sh (mainly Python, Alembic and OSL), see T83246 and T85365.
    • Updated i18n translations.
    • Updated py API docs.
    • Meetings.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Build: OpenColorIO 2.0.0 support for make deps and install_deps.sh (D10270).
    • Reviewed LibOverride: Only show relevant operators in outliner menu (D10301).
    • Reviewed Fix T83592: Crash when deleting or reloading linked scene (D10046).
    • Reviewed LibOverride: Added log statements in liboverride operator functions (D10303).
    • Reviewed Animation: Add PreviewImage to bAction struct (D10306).
    • Fixed (unreported) Liboverride: clean-up/sanitize tagging of root overrides (rB95703d19).
Fixed: 0; unreported Fix: 1; Reviewed: 5; Closed: 0;

Week 393 - 01/23 to 01/29

Week spent mostly on meetings, and enhancing overrides' resync process (plus some on-going refactor of undo system code).

Note: Sort of skipped bug sprint this time, since there were not so many bug I could have worked on (especially none critical for 2.92), and other projects are becoming somewhat urgent to tackle.

Next week: Probably some more undo work, and overrides project startup.

  • Misc:
    • Committed enhancements/fixes to LibOverride resync process (rB2a81d948, part of T83811).
    • Refactored par of ED undo code (rB2a8122fb, D10112, related to T83806)
    • Worked on refactor work for some current undo issues (T83806, D10227).
    • Work on enhancements/fixes to LibOverride resync process (T83811).
    • Patch to filter out non-assets IDs in bpy.data.libraries.load() utils (D10237).
    • Some documentation work (mostly skeletal notes for undo system and overrides, https://wiki.blender.org/wiki/Source).
    • Updated i18n translations.
    • Updated py API docs.
    • Meetings.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Fix unused result from mmap() call (D10223).
    • Reviewed Fix T85110: moving markers num input confuses time vs frames (D10225).
    • Fixed T85124 Undo assert changing property in redo panel (rB3b66f40d).
Fixed: 3; unreported Fix: 1; Reviewed: 2; Closed: 1;

Week 392 - 01/16 to 01/22

Week spent mainly on a few refactors in core ID management code.

Next week: bug sprint.

  • Misc:
    • Modifiers copy refactor (T82945, D10148, rBbc95c249).
    • Finished some refactor of BMain relations temp data (D10164, ).
    • Updated i18n translations.
    • Updated py API docs.
    • Meetings.
    • Studio technical support.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Fix T84600: prevent bone groups operators on proxies/overrides (D10131).
    • Reviewed Rename 'Make Links' to 'Link/Transfer Data' (D10090).
    • Fixed T84758 Blender considers all materials to be overridden (rB79dd9fed).
    • Fixed T84739 Crash with curve brush in sculpt mode (rB9f2271d3).
    • Fixed T82503 LibOverride: Add an 'post apply' callback to IDTypeInfo (rBbe7106a9).
    • Fixed (unreported) LibOverride: hair cache settings not working (rBcd8893d4).
Fixed: 3; unreported Fix: 1; Reviewed: 2; Closed: 1;

Week 391 - 01/09 to 01/15

Week spent mainly over getting undo system cleaner/clearer, and a few hairy bug fixes.

Next week: More undo system work, and hopefully more time for overrides too.

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Worked on refactor work for some current undo issues (T83806, D10033, rB26fd55fa, D10112, T84703).
    • General LibOverride cleanups and minor updates.
    • Meetings.
    • Studio technical support.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Fix T84327: outliner_id_copy_tag was only copying from expanded nodes (D9995, rBf0ae0f49).
    • Reviewed Fix T77844: Expose 'ViewLayer.object_bases' to RNA/Python API (D10028).
    • Reviewed Fix detection of OpenSUSE and other distributions (that are not deb, arch or rpm-based) like Slackware (D10062).
    • Reviewed Geometry Nodes: Enable Exposing object and collection sockets (D10056).
    • Reviewed Fix T81965: Library-Override Not able to edit Keyframe properties (D10091).
    • Reviewed Geometry Nodes: Enable Exposing object and collection sockets (D10056).
    • Reviewed RNA: allow editing pointer IDProperty values from the UI (D10098).
    • Investigated T84397 Creating and removing many objects very quickly causes a crash (D10077).
    • Fixed T83422 Dimensions incorrect after undoing change to an object's dimension if it has a Mirror modifier (D9789, rB2a8b987e).
    • Fixed T84373 Overrides : shapes keys driven by armature don't work on second instance (rB31905667).
    • Fixed (unreported) missing IDType init in ViewLayer tests (rB2f9073ad).
    • Fixed (unreported) embedded IDs creation bypassing ID management completely (rB1a26d157).
    • Fixed (unreported) NLA liboverride issues re tracks handling (rB89ae4a7a).
    • Fixed (unreported) copying liboverride of mesh breaks overrides of shape keys (rB69a7015e).
Fixed: 2; unreported Fix: 4; Investigated: 1; Reviewed: 7; Closed: 1;

Week 390 - 01/02 to 01/08

Bug sprint week, ended up spending most of it over undo issues.

Next week; Maybe more undo work, or liboverride.

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Investigated some current undo issues which will require some design and refactor work (T83806, D10033, several minor cleanup commits).
    • Meetings (DevOps).
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Fix T84367: Fix crash when showing invalid/legacy constraints (D9987).
    • Reviewed Use the term "N-gon" instead of "Polygon" for triangulation method (D10022).
    • Reviewed Fix T82945: Crash when dragging modifiers in Outliner (D9636).
    • Reviewed Fix T84475: Outliner missing update when adding IDs to main via RNA (D10030).
    • Reviewed Surface Deform: optimize handling of the vertex group weight (D10015).
    • Reviewed Surface Deform: optimize memory allocation in the evaluation code (D10040).
    • Reviewed Fix T84475: Outliner missing update when adding IDs to main via RNA (D10030).
    • Reviewed Guarded allocator: Sanity check MEM_dupallocN() gets valid pointer passed (D10007).
    • Reviewed UI: Sanitize threaded preview creation with undo (D9974).
    • Reviewed Fix T83592: Crash when deleting or reloading linked scene (D83592).
    • Reviewed Forbid deleting last local scene (D10049).
    • Investigated T84156 Boolean Modifier is evaluated if an object linked to the cutter object is link-duplicated.
    • Fixed T84202 Sculpt crash after remesh (mask operators, cloth brush, ...) (D9951, rB6672cbeb).
    • Fixed (unreported) mistake in rBef90a8e12caf in data transfer code (rB02d1f148).
Fixed: 1; unreported Fix: 1; Investigated: 1; Reviewed: 11; Closed: 3;

Week 389 - 12/26 to 01/01

Not so productive week, mostly spent on lib override work regarding resync issues.

Next week: Bug sprint.

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Worked on T84084 Assert/crash during COW phase of depsgraph evaluation due to mismatch mask info in code updating mesh data from multires subdiv ccg runtime data (rB26c34a2a).
    • LibOverride: Better handling of missing linked data during resync (TT83811).
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Fix NURBS Extruding multiple points only moves existing points (D9934).
    • Reviewed Fix T79146: Sculpt Mode lags until the entire mesh is visible (D9935).
    • Reviewed Add support for Zstd compression for .blend files (D5799).
    • Reviewed UI: Default duplicate operator for data-block selectors (D9946).
    • Investigated T84117 Crash when using to_mesh() on a depsgraph object in a driver.
    • Investigated some current undo issues which will require some design and refactor work (T83806).
    • Investigated T84202 Sculpt crash after remesh (mask operators, cloth brush, ...) (D9951).
    • Fixed T83749 Obj Material transparencies not automatically connected correctly when using jpeg (rBae824103).
    • Fixed T84091 Crash when going to Properties Editor object properties with Custom Property containing nested dictionary [named "asset_data"] (rBad63d2f6).
Fixed: 2; Investigated: 3; Reviewed: 4; Closed: 2;