User:Mont29/Foundation/2020

Weekly Reports for Year 2020

Week 341 - 03/21 to 03/27

Second Covid week, not easy to find motivation, especially with somewhat boring tasks - mostly did reviews…

Next week, mostly tracker (bug fixes) probably. And move libquery code to new IDTypeInfo system on Friday?

  • Misc:
    • Added invert mapping option to proximity weight edit modifier, and some cleanup (rBbb26c1359e4f4b).
    • Try to understand what cause full re-evaluation of depsgraph in new undocode in some cases (i.e. making undo slow again). Not much luck so far.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Fix T74195: Solidify Complex Dissolve Crash (D7214, rBee4645207f76a5d).
    • Reviewed Change solidify's material offset in complex mode to conform with simple mode (D7215, rB241248223a644).
    • Reviewed Modifiers: Vertex Weight Edit add invert curve falloff option (D6899, rB26ef4fa85ef4e).
    • Reviewed Copy active view layer, add empty view layer (D6862, rBd1972e50cbef).
    • Reviewed Modifiers: Warp modifier add bone from and bone to options when using armature objects (D6820, rBba1f7acc3f50).
    • Reviewed Modifiers: Solidify add option to assign shell geometry to selected vertex group (D6903, rBbd86edf11631).
    • Reviewed Surface Deform modifier: add vertex group and strength control (D6894, rB6e505a45a116).
    • Reviewed install_deps: Enable PIC in Python static library (D7177, rB0a02c288aa25).
    • Reviewed Add ScreenRender addon (D7180).
    • Reviewed Fix T64573: RNA_path_from_ID_to_property fails for pointcaches (D7115).
    • Reviewed Mesh Edit: preserve Custom Normal vectors in topology operators (D4994).
    • Fixed T74959 error message update translation (rB9607e5498583).
Fixed: 1; Reviewed: 11; Closed: 3;

Week 340 - 03/14 to 03/20

Covid week, kind of loosing lots of time on non-dev topics... Also lost two days on some very stupid mistake in IDTypeInfo cleanup. But did finally merge undo speedup work to master!

Next week, tracker and patch review (both are becoming quiet urgents).

  • Bug Tracker:
    • BT misc (general check, assign & close work).
Closed: 3;

Week 339 - 03/07 to 03/13

Fixed/refined first stage of undo speed-up project, and prepared move to IDTypeInfo for data-blocks (Cleanup Friday).

Next week, hopefully we can finally merge experimental undo speed-up in master. And probably some more cleanups in ID management code. And patch review.

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Finished moving ID types to new IDTypeInfo system (T73719).
      • Did some more cleanup in ID management related code.
    • Worked on undo speedup.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Blenloader API (D7061).
    • Reviewed Add methods foreach_get() and foreach_set() to pyrna_prop_array class for fast access to array data. (D7053).
    • Fixed T74670 copy paste objects from one instance of blender to another instance results in immediate crash of instance being pasted into (rB11e48277386c).
    • Fixed T74699 File browser closing while loading crash (rBebf3c8791236).
    • Probably Fixed T74609 File Selector Crashes Showing Thumbnails (rB525bd62557e3).
    • Fixed (unreported) bad user refcounting of viewer image ID (rB9ef7759bf03).
Fixed: 3; Unreported Fix: 1; Reviewed: 2;

Week 338 - 02/29 to 03/06

Finished first stage of undo speed-up project, and finished move to IDTypeInfo for data-blocks (Cleanup Friday).

Next week, finish the move to IDTypeInfo, and prepare undo speed-up for initial 'experimental' merge in master.

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Worked on undo speedup (general process and patch are now agreed on, only some fixes remain necessary before initial 'experimental' merge in master).
    • Finalized & committed initial refactor towards using an IDTypeInfo (T73719, D6966, rBc328049535a4b).
      • Updated task for Cleanup Friday (T73719).
    • CleanupFriday: Moved a bunch of ID types to new IDTypeInfo system (T73719).
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed RNA: support 64 bit boolean bitflags (D7002).
    • Reviewed IDs: modify wm.previews_clear operator to no longer use bitflag enum (D7003).
    • Reviewed IDs: change FILTER_ID_* to 64 bit to make space for new ID types (D7004).
    • Reviewed Objects: add Volume object type, and prototypes for Hair and PointCloud (D6945).
    • Reviewed Core XR Support [part 1]: Add OpenXR-SDK dependency and WITH_OPENXR build option (D6188).
    • Reviewed Fix T71871: Quadriflow remesh operator don't stack operations (D7006).
    • Reviewed Modifiers: Wave add invert vgroup option (D6893, rB059f3c1a7eb8).
    • Fixed T74335 Text.use_module "Online Manual" leads to TextCurve pages (rBbd25df3d6805).
Fixed: 1; Reviewed: 7; Closed: 2;

Week 337 - 02/22 to 02/28

Essentially worked on undo-speedup related tasks, besides regular tracker work.

Next week, undo speed-up again (this should be the last steps of actual dev there, then it will be testing & stabilizing).

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Worked on undo speedup (Created new diff D6937 for 'unique ID memaddresses', and updated D6580).
    • Serious fix/upgrade of install_deps.sh helper (rB6dd3e7d84da6).
    • Worked on initial refactor towards using an IDTypeInfo structure for common data-blocks data and handling (T73719).
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Fixed T74003 Autocomplete bug with mesh.loop_triangles. in Blender Python Consolle (rB69c587888b5e).
    • Fixed T74099 Can`t apply modifier, if mesh have fake user (rB14856e149ff5c).
    • Fixed T73371 Appending Collections to a new empty file and trying to save that file causes Blender to crash (rB2d423479bdea).
    • Reviewed Objects: add Volume object type, and prototypes for Hair and PointCloud (D6945).
Fixed: 3; Reviewed: 1; Closed: 8;

Week 336 - 02/15 to 02/21

Essentially worked on undo-speedup related tasks, and finding/fixing bugs on the way.

Next week, undo speed-up again.

  • Misc:
    • Updated i18n translations.
      • Fixed many UI messages typos and issues.
    • Updated py API docs.
    • Finalized & Committed readfile: Move ID refcounting to libquery (D6881, rB367ecff15d74).
    • Worked on possible solution for Drivers on hide_viewport and hide_render are unreliable, and throw warnings on linked-but-not-proxied objects (T73593).
    • Asset meeting.
    • Worked on undo speedup.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Fixed T73817 Shape key users not properly mapped when duplicating an object & mesh (rB3a53ae8d4bd3).
    • Fixed T73941 Custom normals from normal edit modifier ignored by further modifiers (rBcfdb5b9a8b07).
    • Fixed T72751 Timeline crash from overridden scene (rBe317e9f6c75c).
    • Fixed T74009 Adding bpy.ops.outliner.orphans_purge() to the QuickMenu leaves it inaccessible, because poll() prevents it from being run (rBd772c6ea315c).
    • Reviewed Modifiers: Warp modifier add bone from and bone to options when using armature objects (D6820).
    • Reviewed UI: always use international font (D6854).
    • Reviewed Modifiers: UVWarp modifier add invert vgroup option (D6841, rB20605c4b515e).
    • Reviewed Modifiers: Laplacian Smooth modifier add invert vgroup option (D6842, rBd0cc9b522dfb5).
    • Reviewed Modifiers: Laplacian Deform modifier add invert vgroup option (D6843, rBe30d8f45ef1).
    • Reviewed Modifiers: Explode modifier add invert vgroup option (D6844, rB5df0f8bffb55).
    • Reviewed Modifiers: Bevel modifier add invert vgroup option (D6845, rB6cd4363c0c3e).
Fixed: 4; Reviewed: 7; Closed: 13;

Week 335 - 02/08 to 02/14

Essentially worked on undo-speedup related tasks (per-requesit works, not actually undo itself), and finding/fixing bugs on the way.

Next week, undo speed-up again.

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
      • Added multi-tasking option to API docs generator, much faster with that (rB379ee3e5277905).
    • Kept working on BKE_library refactor (see T72604).
    • Updated install_deps script for latest lib versions requirements (rBc6e28f65139d).
    • Worked on basic unittests for blenfile read/write and library linking.
    • Worked on undo speedup.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Fixed (unreported) fully broken bpy.data.user_map() helper (rB3ec3c5b557ded).
    • Fixed (unreported) private/embedded IDs being added to bpy.data.user_map() dict (rBbe40d86e35b).
    • Reviewed Fix T63635: Node Wrangler does not set relative paths for images using Add Texture Setup (Ctrl+Shift+T) (D6756).
    • Reviewed Modifiers: Fix bug where UVWarp Modifier would try to get bone matrix from a non armature object (D6809, rB1f28af6a7999).
    • Reviewed Modifiers: Hook Modifier add invert vgroup option (D6817, rBe32457952b45e).
    • Reviewed Modifiers: Weld Modifier add invert vgroup option (D6818, rBcd57c9e310e2).
    • Reviewed Modifiers: Vertex Weight Modifiers add invert vgroup option (D6819, rBcc085e228de705).
Unreported Fixes: 2; Reviewed: 5;

Week 334 - 02/01 to 02/07

Mostly various cleanups and refactor this week, related to undo speedup project. Also somewhat small week, with the move to Amsterdam in the middle of it.

Next week, more cleanup to finish, and mainly undo-seedup work again, hopefully by its end we'll have all planned changes implemented (yeah, copy/paste ftw!).

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Moved to A'Dam.
    • Setup worspace again at studio.
    • Committed Readfile: Proper fix for recalc flags clearing in non-real IDs (D6711, rB06c560864607).
    • Committed Refactor readfile's liblink code. (D6727, rBb841167ee35a).
    • Worked on & committed Readfile: refactor/factorize more handling of common ID data (D6764, rB7954e672c555).
    • Worked on undo speedup improvements.
    • Worked on clean-up task Proposal: BKE_library and BKE_main API naming: prefixes conventions (T72604).
Closed: 2; Fixed: 1; Reviewed: 5;

Week 333 - 01/25 to 01/31

Mostly undo work this week, after Brecht’s review and suggestions. Things are starting to look nice, but there is still some work ahead.

Next week, aside from moving back to Amsterdam, will mainly be undo-seedup work again, hopefully by its end we'll have all planned changes implemented.

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Updated/refined tasks related to data management performances improvements (T73359).
    • Worked on undo speedup improvements.
    • Submitted refactor of liblink code in readfile area (would be useful for undo work, see D6727).
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Fixed T73399 Crash trying to move the origin of an empty (rB34c8ba6d3e).
    • Investigated (unreported) Readfile: Proper fix for recalc flags clearing in non-real IDs (D6711).
    • Reviewed Cast modifier invert vgroup option (D6671, rB1094e560413d).
Closed: 4; Fixed: 1; Investigated: 1; Reviewed: 1;

Week 332 - 01/18 to 01/24

Not a big week, mostly tracker again (triaging & time-sink bug fixes, but also patch review, patch discussions, tasks management, etc.).

Next week will be mainly tracker, hopefully some actual liboverrides work ('new' features), and likely back to undo-seedup work.

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Updated/clarified manual re auto-smooth and clnors (related to T70810).
    • Worked on undo speedup improvements.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Fixed T72619 Overrides with particle systems crash (rB56c7ee99b858).
    • Fixed T73336 Blender crashes when trying to copy a PointerProperty to selected objects (rB316d2c15220d).
    • Reviewed CMake: Refactor external dependencies handling (D6642).
    • Reviewed FBX Import Addon: Import focus distance for camera (D6666).
Closed: 2; Fixed: 2; Reviewed: 2;

Week 331 - 01/11 to 01/17

Transition week, undo-speedup project now waits for initial design green light. Resumed tracker work, both triaging and fixing, with 2.82 coming closer now.

Next week will be mainly tracker, and 'better' resuming of liboverrides work.

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Worked on undo speed improvements.
    • Finalized & published initial ('engeneering investigation') patch for undo speed-up, D6580.
    • Updated tasks for liboverride project (T53500 and related).
    • Updated install_deps for latest library version updates, see D6593.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Fixed T71798 Full Copy Scene produce Orphan Data objects (rBac723db57fd8).
    • Fixed T72255 Video import file path error when importing video from recursive directory, using "Add -> Movie" menu option (rB51add8e6d0a1).
    • Fixed T73125 Crash when opening a file containing a Line Style (rB3ee6d74f933a).
    • Fixed T72887 Crash when issuing an undo operation immediately after linking a collection when an outliner's display mode is set to "Blender File" (rBd74f9c4b7b4f).
    • Fixed T73170 New Scene -> "Full Copy" Crashes Blender (rBfb0fc1d61331).
    • Fixed (unreported) broken PY API doc gen after recent GP changes (rBdfa3f51e5245a4).
    • Reviewed Fix T72861: Viewport Render Keyframes ignores Grease Pencil and Shape Keys (D6558).
    • Reviewed Fix (unreported) surface deform modifier not reporting its errors in the UI (D6601).
Closed: 7; Fixed: 5; Unreported Fixes: 1; Reviewed: 2;

Week 330 - 01/04 to 01/10

Week spent mostly again on undo project, and some code reviews.

Next week will be undo again (plan on getting initial review over the proof of concept code), hopefully resuming some liboverrides work, and tracker curfew duties.

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Worked on undo speed improvements.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
    • Reviewed Edit Mesh: Use multithreading in other parts of Auto Merge & Split (D6528).
    • Reviewed Fix T72667: Crash when collections unlink an edit-mesh (D6526).
    • Reviewed Fix broken nodes copying, calling to copy-API and user counting (D6484).
    • Reviewed Fix T72861: Viewport Render Keyframes ignores Grease Pencil and Shape Keys (D6558).
Closed: 1; Reviewed: 4;

Week 329 - 12/28 to 01/03

Again a fairly small week, but think I finally got a satisfying general design (and proof of concept implementation) for the undo speedup (see new branch [undo-experiments-idnames https://developer.blender.org/diffusion/B/history/undo-experiments-idnames/] ).

Next week will be mainly dedicated again to undo speedup project.

  • Misc:
    • Updated i18n translations.
    • Updated py API docs.
    • Worked on undo speed improvements.
  • Bug Tracker:
    • BT misc (general check, assign & close work).
Closed: 1;