User:Manowii/Reports/2022

Week 157: 27th June

This week: Triaging and bug fixing.

Next Week: Triaging and bug fixing.

Reviews

  • D15270: Fix T99070: Apply transform fails to clear delta transform values.

Fixes

  • Fixed T98882: Regression: Gradient colors in a Grease Pencil material change… (270ed1c716)
  • Fixed T96776: Assets dropped upside down when looking through camera (317dfc1735)
  • Fixed T84369: Fluid: Missing cache invalidation when properties on non-domain… (67e23b4b29)
Fixed: 3
Reviewed: 0
Closed: 12
Confirmed: 10
Total triaged: 19


Week 156: 20th June

This week: At rest due to severe cold.

Next Week: Triaging and bug fixing.

Fixed: 0
Reviewed: 0
Closed: 0
Confirmed: 0
Total triaged: 0


Week 155: 13th June

This week: Triaging. Activity was reduced as on Wednesday I caught a cold so I was hospitalized.

Next Week: Since I am in recovery, the next week will be focused on my health (I talked to Philipp in order to adjust the triaging team activities).

Reviews

  • D15201: Fix T86076 MPEG Settings Ignored at Render.
  • D15186: Fix for T98840.
Fixed: 0
Reviewed: 0
Closed: 9
Confirmed: 11
Total triaged: 20


Week 154: 6th June

This week: Triaging and bug fixing.

Next Week: Triaging and bug fixing.

Commits

  • Cleanup: potential dereferencing of a NULL pointer (1456f30b02)
  • Remove workaround for drawing the rotation gizmo (ea182deeb9)

Fixes

  • Fixed variable being used without being initialized (6d726192be)
  • Fixed T98688: Snapping not working in curve objects with evaluated geometry (96f88511ee)
  • Fixed assert triggered when snapping to evaluated geometry of a Curve (8a02696724)
  • Fixed drawing increments after running Spin gizmo (d422715094)
Fixed: 1
Reviewed: 0
Closed: 7
Confirmed: 5
Total triaged: 11


Week 153: 30th May

This week: Triaging (spent a bit of time also testing a new selection algorithm).

Next Week: Triaging and bug fixing.

Reviews

  • D15088: Cleanup: Move remaining mesh draw code to C++
Fixed: 0
Reviewed: 1
Closed: 10
Confirmed: 4
Total triaged: 14


Week 152: 23rd May

This week: Triaging an bug fixing (I also worked on a proposal to improve navigation D15028).

Next Week: Triaging and bug fixing.

Reviews

  • D15037: Refactor: Snap-related. Clarified attribute names and refactored #defines into enums.

Commits

  • Addons: Update Snap Utilities Line documentation (M9297M9297)
  • Snap Utilities Line: update to new 'GPUShaderCreateInfo' (A83fa6728e)

Fixes

  • Fixed (unreported): cyclic snap of curve handles (49368c734b)
  • Fixed GPUIndexBuf not working in python (5744e7d247)
Fixed: 0
Reviewed: 1
Closed: 15
Confirmed: 4
Total triaged: 19


Week 151: 16th May

This week: Triaging, bug fixes (and continued an investigation to improve the selection code).

Next Week: Triaging and bug fixing.

Commits

  • Cleanup: rename 'WeldPoly' member 'len' to 'loop_len' (22812579bb)

Fixes

  • Fixed T98230: Automatic Constraint doesn't work if cursor is not moving (bc6965cb98)
  • Fixed assertion raised in Merge By Distance (769cdccd0e)
  • Fixed compilation errors with 'USE_WELD_DEBUG' (7ace6dc496)


Fixed: 1
Reviewed: 0
Closed: 9
Confirmed: 8
Total triaged: 16


Week 150: 9th May

This week: Triaging, bug fixes and little research to improve the selection code.

Next Week: Triaging and bug fixing.

Commits

  • Transform: use a threshold for UV snapping (7ed08e88ac)

Fixes

  • Fixed T97835: crash when creating hair particle system on Mac (44bd434a57)
  • Fixed T97872: Annotation lines lost AA (470cbad51a)
  • Fixed cursor snap not acting on selected UVs (046b45749c)


Fixed: 2
Reviewed: 0
Closed: 10
Confirmed: 2
Total triaged: 10


Week 149: 2nd May

This week: Triaging, bug fixes and small improvements to the UV snapping code.

Next Week: Triaging and bug fixing.

Reviews

  • D14855: Fix T97853: Crash with edit mode X-ray and subdivision.

Commits

  • Transform: use a threshold for UV snapping (d2271cf939)

Fixes

  • Fixed T97872: Annotation lines lost AA (a0a99fb252)
  • Fixed T97835: crash when creating hair particle system on Mac (adbe71c3fa)


Fixed: 2
Reviewed: 1
Closed: 12
Confirmed: 8
Total triaged: 18


Week 148: 25th April

This week: Triaging, bug fixes, small improvements to the snapping code e some work related to the gpu and draw module.

Next Week: Triaging and bug fixing.

Commits

  • Overlay: port paint shaders to use 'GPUShaderCreateInfo' (57b4efc250)
  • Select Engine: port shader to use 'GPUShaderCreateInfo' (3d877c8a0d)
  • Cleanup: silence unused variable warnings (f38f12cbbc)
  • Snap Gizmo: update props using gizmo's snap_state (f4718d52f3)
  • Snap Cursor: split 'ED_view3d_cursor_snap_data_get' (22f5c05cb3)
  • Transform Snap Refactor: dedicate ghash to different SnapData types (e99cb91530)
  • Cleanup: Turn some 'eTFlag' into macros (d30f701e84)

Fixes

  • Fix non-face oriented snap cursor in dragdrop (853713336f)
  • Fix T93285: Wrong instance order when instancing a collection (f3d5114c41)
  • Fix T97401: Snap options ignored for Nurbs surfaces (35dc4ba9e2)


Fixed: 2
Reviewed: 0
Closed: 14
Confirmed: 8
Total triaged: 20


Week 147: 18th April

This week: Triaging, bug fixing, some PyGPU related changes and small improvements to the snapping code.

Next Week: Triaging and bug fixing.

Requested review of D14683: Refactor: Transform Snap Object: use EditMesh as hashmap key for the data of editmeshes.

Commits

  • gpu.types.GPUBatch: warn about deprecated primitive types (e2d8b6dc06)
  • Snap Utilities Line: increment version number (Aa254b56d4)
  • Cleanup: formatting using autopep8 (A16c87dcfb)
  • PyGPU: remove outdated function 'code_from_builtin' (3e98331a09)
  • Cleanup: remove redundant 'DEG_get_original_object' call (5da02548e9)
  • Transform: small optimization in snap to edit mesh (a0c2d6bf85)

Fixes

  • Fixed (unreported): Placement Tool not orienting the Object to normal (75aa5ecbda)
  • Fixed T97490: snap to multiple objects with linked data can crash (9de3ed5c82)
  • Fixed T97458: Snap_Utilities_Line rotate navigation not working (A1ca9acffc)
  • Fixed call of 'BLI_assert' instead 'BLI_assert_msg' (b90e892a17)
  • Fixed assert on meshes without mloop in snap code (bec057a453)


Fixed: 2
Reviewed: 0
Closed: 10
Confirmed: 3
Total triaged: 11


Week 146: 11th April

This week: Triaging and bug fixing, and worked on porting 'StageInterfaceInfo' and 'ShaderCreateInfo' to python.

Next Week: Triaging and bug fixing.

Commits

  • Snap Utilities Line: consider UI scaling for drawing and snapping (A754d05ac7)
  • gpy.types.GPUUniformBuf: support any object exposing buffer interface (af17676005)
  • gpu.types.Buffer: fill buffer interface with just what is requested (132576ebb1)
  • pyGPU: Port 'StageInterfaceInfo' and 'ShaderCreateInfo' types (9bc678969a)
  • Cleanup: redundant logical not (ee9688da99)
  • PyGPU: make sure the UniformBuffer is padded to 16 bytes (4aa9888854)
  • Cleanup: Mesh Snap Utilities Line: Formating (A295fb9b08)

Fixes

  • Fixed crash when loading Blender due to recent change (48d2f536e1)
  • Fixed missing clip planes update in Snap Utilities Line (Abffb84a05)
  • Fixed some usages of 'GPU_shader_get_uniform_block' (9c09e5ba24)
  • Fixed regression with Clip Planes in Snap Utilities Line (A209ee2887)
  • Fixed size of MAT3 and MAT4 in GPUShaderCreateInfo.push_constant (8fad71799f)
  • Fixed cases where 'Py_buffer' might not be released (17a19069db)
  • Fixed possible pointer being freed without being allocated in pygpu module (cd4a9c488f)
  • Fixed edcrash when creating a 'gpu.types.Buffer' (07cacb6d14)


Fixed: 0
Reviewed: 0
Closed: 11
Confirmed: 3
Total triaged: 14


Week 145: 4th April

This week: Triaging and bug fixing.

Next Week: Triaging and bug fixing.

Commits

  • BVH Utils: use fall-through in 'BKE_bvhtree_from_mesh_get' (eb470bfbfe)
  • Cleanup: remove workaround to set treedata members (99b82116ef)
  • BVH Utils: remove 'isolate' parameter (931ae424b9)
  • BVH Utils: Remove '_allocated' members from 'BVHTreeFromMesh' (9fbf7f1180)
  • Refactor: remove cache parameters from bvhtree_from_ functions (684b95804e)
  • Refactor: Deduplicate and simplify BVH Utils code (228f7f1c85)

Fixes

  • Fixed T95678: Thumbnails are not working with big / large Objects (0ebcc711fc)


Fixed: 1
Reviewed: 1
Closed: 9
Confirmed: 8
Total triaged: 16



Week 144: 28th March

This week: Triaging, bug fixing and last touches on the new StageInterfaceInfo and ShaderCreateInfo types to the gpu python module (D14497).

Next Week: Triaging, bug fixing and retouching on D14497 if necessary.

Reviews

  • D14496: UI: make snap self inactive if proportional editing.
  • D14475: Cleanup: Move transform_snap_object.c to C++.

Commits

  • Transform: avoid excessive recalculation with 'TREDRAW_SOFT' (df4d6c22cf)
  • Cleanup/Refactor: remove unused 'SNAP_ONLY_ACTIVE' enum parameter (854af0cd09)
  • Transform: Improve 'absolute grid snap' support detection (39df927b4a)
  • Cleanup: transform, use early returns (4c66021ccc)

Fixes

  • Fixed T96728: 'Automatic Constraint' using the wrong orientation (21e72496a6)
  • Fixed T96812: Regression: Snapping is broken with proportional editing (2e99295d5e)


Fixed: 2
Reviewed: 1
Closed: 12
Confirmed: 12
Total triaged: 22


Week 143: 21st March

This week: A bit of triaging, bug fixing and worked on porting the new StageInterfaceInfo and ShaderCreateInfo from the gpu module to python.

Next Week: Finishing touches on the new python objects and triaging.

Fixes

  • Fixed T96711: snap in edit mode for selected objects does not work (4b35d6950d)


Fixed: 1
Reviewed: 0
Closed: 5
Confirmed: 9
Total triaged: 13


Week 142: 14th March

This week: Triaging, bug fixing and I continued the work on D13648 D12469 to support animation in the visibility of collections.

Next Week: Triaging mostly

Commits

  • Cleanup: remove redundant 'extern StructRNA' declarations (256d36683b)

Fixes

  • Fixed T96510: ASAN failure when selecting text in Text Editor (8ecaa2d624)


Fixed: 1
Reviewed: 0
Closed: 17
Confirmed: 13
Total triaged: 29


Week 141: 7th March

This week: Triaging and bug fixing.

Next Week: Triaging

Commits

  • Transform/UI: individualize the option to use snap per editor type (e3de755ae3)


Fixed: 0
Reviewed: 0
Closed: 17
Confirmed: 9
Total triaged: 26


Week 140: 28th February

This week: Triaging and bug fixing (and some local work on D14177).

Next Week: Triaging and bug fixing.

Reviews

  • D14243: Fix T96156: Snap to 3D cursor can't be undone.

Fixes

  • Fixed T95608: Mac issues with drag drop on multi-monitor (9bd586a01e)
  • Fixed wrong object mode checking in snap code (8e88af9934)


Fixed: 1
Reviewed: 1
Closed: 15
Confirmed: 13
Total triaged: 27


Week 139: 21st February

This week: Triaging and bug fixing (and some local work in the transform tools - 8ac8bdaf74).

Next Week: Triaging and bug fixing.

Commits

  • Ghost/Event System: Support mapping more keys (4ee4b61dd8)

Fixes

  • Fixed errors in 'gpu.state' documentation (75be58c63d)
  • Fixed wrong method name in gpu documentation (18d3d283ec)
  • Fixed (unreported): Issues with 'SNAP_NOT_SELECTED' for pose and edit modes (459d9c1e3d)


Fixed: 0
Reviewed: 0
Closed: 6
Confirmed: 7
Total triaged: 13


Week 138: 14th February

This week: Triaging and bug fixing (and some local work in the transform tools).

Next Week: Triaging and bug fixing.

Commits

Fixes

  • Fixed wrong method name in gpu documentation (59aaf2036e)
  • Fixed errors in 'gpu.state' documentation (9189191c5b)


Fixed: 0
Reviewed: 0
Closed: 17
Confirmed: 8
Total triaged: 25


Week 137: 7th February

This week: Triaging and bug fixing.

Next Week: Triaging and bug fixing.

Reviews

  • D13990: Fix T91253: Slow pose bone selection with many bones.

Fixes

  • Fixed (unreported): Issues with 'SNAP_NOT_SELECTED' for pose and edit modes (52be063012)
  • Fixed error in b1b1a74af15b (81d2eda2bf)
  • Fixed error in ff5e8e6d5353 (6b914a43ad)
Fixed: 0
Reviewed: 0
Closed: 27
Confirmed: 13
Total triaged: 40


Week 136: 31st January

This week: Triaging, bug fixing (also investigated and did some cleanups in the 3D View navigation code).

Next Week: Triaging and bug fixing.

Reviews

  • D13990: Fix T91253: Slow pose bone selection with many bones.

Commits

  • Cleanup: set 'op->customdata' out of 'viewops_data_create' (b1b1a74af1)
  • Cleanup: merge functions with similar usage (ec9f237a9e)
  • View3D: move some of the early returns from operators to the poll function (3d973d01fa)
  • Cleanup: Rename 'TRACKBALLSIZE' to 'V3D_OP_TRACKBALLSIZE' (b4e06bd7d4)
  • Cleanup: Split View3D navigation code into specific compilation units (1963ad52ce)
  • Cleanup: restructure 'transform_convert_pose_transflags_update' (ff5e8e6d53)

Fixes

  • Fixed T95238: BPY Documentation for Tablet Pressure is Incorrect (46abc6ce25)
Fixed: 1
Reviewed: 1
Closed: 21
Confirmed: 13
Total triaged: 33


Week 135: 24th January

This week: Triaging and bug fixing.

Next Week: Triaging and bug fixing.

Reviews

  • D13907: Geometry Nodes: Port weld modifier to the merge by distance node.

Commits

  • Outliner: avoid creating unnecessary undo steps (3775615aea)
  • Cleanup: Remove unused enum (578baf95e0)

Fixes

  • Fixed T95169: Assert in weld modifier code (52b2769b9c)
Fixed: 1
Reviewed: 1
Closed: 27
Confirmed: 16
Total triaged: 42


Week 134: 17th January

This week: Triaging and bug fixing (I also studied a solution for navigation while transforming locally).

Next Week: Triaging and bug fixing.

Patches (under review)

  • D13898: Fix T94760: Crashe building BMesh when opening file.
  • D13896: Fix T93113: Redo Panel of transform sculpt operation does not work properly.
  • D13873: Transform: Use a minimum distance for the UV snap threshold.
  • D13853: Calculate the median point for individual origins of poly and nurbs spline types.

Commits

  • Cleanup: deduplicate condition in transform curve code (59fcbdd815)

Fixes

  • Fixed T94202: GPUFrameBuffer: wrong refcount in the buffer passed for read_color… (2e5aecf557)
  • Fixed T95029: Arrow gizmo always uses normal direction (9506dcf675)
Fixed: 2
Reviewed: 0
Closed: 17
Confirmed: 9
Total triaged: 24


Week 133: 10th January

This week: Triaging and bug fixing.

Next Week: Triaging, bug fixing and investigate solutions for transformation with navigation.

Commits

  • Cleanup: simplify parameters (d914cfcb7a)
  • Cleanup: remove unnecessary 'use_opengl_context' parameter (fc0f315106)

Fixes

  • Fixed T94951: Crash when snapping (608d51c9c8)
  • Fixed T94751: ground created by Setup Tracking Scene not marked as Shadow Catcher (ab125f466c)
  • Fixed T94728: Auto Depth problem with Cliping Region (6774cae3f2)
Fixed: 3
Reviewed: 0
Closed: 13
Confirmed: 7
Total triaged: 17


Week 132: 3rd January

This week: Triaging and bug fixing.

Next Week: Triaging, bug fixing and investigate solutions for transformation with navigation.

Fixes

  • Fixed T94078: Wrong Bound Box calculated for curves (5560f32447)
  • Fixed T94392: 3D Cursor surface projection onto hidden geometry (8189471912)
Fixed: 2
Reviewed: 0
Closed: 5
Confirmed: 2
Total triaged: 5