User:Manowii/Reports/2019

Week 23: 2nd - 6th December

This week I distributed my time between bug triage and the Weld Modifier proposal (patch almost done).

Fixes

  • Fixed T72071: Crash on snap to edge (0f521ca4d962).
  • Fixed T72076: Edit mode circle selection inconsistency with animation (8b3084795208).
Fixed: 2; Unreported fixes: 0; Reviewed: 0; Closed: 10


Week 22: 25th - 29th November

As usual, I focused on bug triage. I also started working on an idea for the Weld Modifier (for evaluation)..

Fixes

  • Fixed T72024: Transform Snap: Alingn Rotation distorts object (3a5d398aaf55).
  • Fixed T71558: Hair particles: Brush effect not occluded by emitter geometry (a8d29ad6e062).
Fixed: 2; Unreported fixes: 0; Reviewed: 0; Closed: 29


Week 21: 18th - 22nd November

Week focused on bug triage (asking for more information, closing, assigning developers or fixing).

Fixes

  • Fixed T71273: Bad encoding of utf-8 for Text objects (177dfc6384b9 ).
Fixed: 1; Unreported fixes: 0; Reviewed: 0; Closed: 15


Week 20: 11th - 15nd November

Week focused on bug triage (asking for more information, closing, assigning developers or fixing).

Fixes

  • Fixed T71436: proportional_edit_objects turns off when translating cursor in edit… (Sb720c0f6aa68).
Fixed: 1; Unreported fixes: 0; Reviewed: 0; Closed: 6


Week 19: 4th - 8th November

Week focused on bug triage (asking for more information, closing, assigning developers or fixing).

New patches

  • D6198 Fix T71273: Bad encoding of utf-8 for Text objects

Fixes

  • Fixed T71436: proportional_edit_objects turns off when translating cursor in edit… (b720c0f6aa68).
  • Fixed T69799: Glitches when moving object camera is locked to (4b229f9e2d5d ).
Fixed: 2; Unreported fixes: 0; Reviewed: 0; Closed: 13


Week 18: 28th October - 1st November

Week focused on bug triage (asking for more information, closing, assigning developers or fixing).

Commits

  • Documentation: Update the snapping menu images (M5912).
  • Windows: Replace deprecated SHGetFolderPathW (89e2a8f17aa1).
  • Transform: Add option to exclude back facing geometry from snapping (44d67b6dc8b9).
  • mesh_snap_utilities_line: Cleanup: Silence Warning (A3d8a723c866a).

Fixes

  • Fixed T71124: UV Editor – Proportional Editing Falloff misses some Options (8a5f3d38af96).
  • Fixed T50148: Header: Wrong rounding when moving frames (ce0db668ec04).
Fixed: 2; Unreported fixes: 1; Reviewed: 0; Assigned to: 29; Closed: 8


Week 17: 21st - 25th October

Week focused on bug triage (asking for more information, closing, assigning developers or fixing).

New patches

  • D6135 Fix T50148: Wrong rounding when moving frames

Fixes

  • Fixed T71104: Addon: snap utilites line. Errors with some cuts (A742b8663af7c).
Fixed: 1; Unreported fixes: 0; Reviewed: 0; Assigned to: 22; Closed: 16


Week 16: 14th - 18th October

Week focused on bug triage (asking for more information, closing, assigning developers or resolving).

New patches

  • D6081 Fix T70873: Pivot Center calculation ignores mirror elements

Fixes

  • Fixed T70899: Looptools circle fails when new plane created aligned to view (Aee68a1761192).
  • Fixed T70386: Crash when snapping to edges in specific situations (a0340bddcd6c).
  • Fixed T70729: Multi-object edit UV not transform all meshes (ea2977913592).
  • Fixed T70594: mathutils.geometry.tessellate_polygon flips triangles (b5b56fd3c470).
  • Fixed T70601: Lasso select not functioning correctly in Armature Edit Mode (394bac858d09).
  • Fixed T70386: Crash when snapping to edges in specific situations (cfb6ffd48f77).
Fixed: 6; Unreported fixes: 0; Reviewed: 0; Assigned to: 48; Closed: 14


Week 15: 7th - 11th October

This week was focused on bug triage (asking for more information, closing, assigning developers and resolving).

Reviews

  • Reviewed UI: Fix grid scale text not having shadows in the 3d view infos (D6025).

Fixes

  • Fixed T70729: Multi-object edit UV not transform all meshes (4e3f186a8c9e).
  • Fixed T70594: mathutils.geometry.tessellate_polygon flips triangles (b718d659c9a5).
  • Fixed T70601: Lasso select not functioning correctly in Armature Edit Mode (234f346c2f93).
  • Fixed T70508: Wrong snapping default in Node Editor (4761028fc75a).
Fixed: 4; Unreported fixes: 0; Reviewed: 0; Assigned to: 40; Closed: 11


Week 14: 30th September - 4th October

This week was focused on bug triage (asking for more information, closing, assigning developers and resolving).

New patches

  • D5995 Bring back the schematic view of the Rigid Body Shape Collision

Commits

  • BT misc (general check, cleanup, assign & close work).
  • GPU: Make sure workaround is supported (bb0b46f78c1e).

Fixes

  • Fixed T70418: Text Underline stays Flat on TextCurve Extrude (629a1c1639cb).
  • Fixed T70328: Crash when editing loopcuts with AutoMerge & Split option (6700027863f1).
  • Fixed T70317: Equal clip range crashing in Hue Correct & RGB Curves Nodes (825a93d7cddd).
Fixed: 3; Unreported fixes: 1; Reviewed: 0; Closed: 17


Week 13: 23rd - 27th September

This week was focused on bug triage (asking for more information, closing, assigning developers and resolving).

Reviews

  • Reviewed Fix T70126: Can't Snap To Vertex With Rigidbody (D5900).
  • Reviewed 3D cursor tool: improve rotation for Orientation set to 'Geometry' (D5885).

Commits

  • BT misc (general check, cleanup, assign & close work).
  • DRW: Deduplicate drw_draw_depth_loop functions (b11272a00745).
  • GPU: AMD: Remove workaround that doesn't work (77f1f13663d3).

Fixes

  • Fixed T69639: Bevel Info bar Width value not affected by Unit Scale (f9d7f690b240).
  • Fixed T70109: Crash with the Data Transfer Modifier (with any 'Edge Data' option) (2a47900fc6a6).
  • Fixed T69743: Armature display issues with Intel 5x0 GPU (22abc205aca2).
Fixed: 3; Unreported fixes: 0; Reviewed: 2; Closed: 10


Week 12: 16th - 20th September

This week was focused on triage and bug fixes.

New patches

  • D5862 Transform: Pose: Partial support for Auto IK + X-Mirror
  • D5821 Fix T69799: Glitches when moving object camera is locked to
  • D5819 Split transform.c in multiple files

Reviews

  • Reviewed Fix T70020: Sculpt mode transform tools fail with cursor orientation (D5848).
  • Reviewed Fix T70006: crash when transforming paint curve edit points in sculpt mode D5837).
  • Reviewed Fix T69804: Transform tools in sculpt mode fails with transformed objects (D5777).
  • Reviewed Fix T69752: Texture paint sampling colors always 'merged down' (D5775).
  • Reviewed UI: Snapping Popover Labels (D5702).

Commits

  • BT misc (general check, cleanup, assign & close work).
  • DRW: Deduplicate drw_draw_depth_loop functions (b11272a00745).
  • GPU: AMD: Remove workaround that doesn't work (77f1f13663d3).

Fixes

  • Fixed T70109: Crash with the Data Transfer Modifier (with any 'Edge Data' option) (8c60205bef31).
  • Fixed T67174: Weight paint gradient has empty redo panel (9dd64cb08832).
  • Fixed T69855: 3DView glitches involving depth buffer (27642f24e1cb).
  • Fixed T69853: Object orientation is wrong with some AMD deprecated drivers (d0c772f68b84).
  • Fixed T69716: Can't select geometry hidden by faces created by modifiers (8f662e84e0b4).
Fixed: 5; Unreported fixes: 0; Reviewed: 5; Closed: 6


Week 11: 9th - 13rd September

This week I focused on implementing the new BM_mesh_intersect_edges tool, triaging and fixing bugs

New/Updated patches
  • D2624 Allow navigating while transforming.
Commits
  • BT misc (general check, cleanup, assign & close work).
  • Reviewed Fix T69037: Automerge is greyed-out in popover (D5618).
  • Transform: AutoMerge & Split: Create and merge vertices at edge intersections (852c72707386).
  • BMesh: New tool BM_mesh_intersect_edges (ca5e1615a10f).
  • BLIKdopBVH: New BLI_bvhtree_overlap_ex utility (f9ef59ccc80d ).
  • Transform: Split transform_conversions into multiple files. (e21939965a9f ).
  • Transform: Edit Mesh: Support mirror on all axes (3bd4f229beb1 ).
Fixes
  • Fixed T69792: Auto-merge split faces creates faces with unrelated wire edges. (c168092014ef ).
  • Fixed T69382: Crash - Regression - GPU Intel HD 4000 (10f70ea73abd ).
  • Fixed unreported: snapping to 3d tracking markers sometimes fails (1b3014f2f4d2 ).
  • Fixed T69458: Edit Mesh selection bug from camera view (6d85280ec3fb ).
  • Transform: Snap: Fix mixed snap without edge (559df2fed9ad).
Fixed: 5; Unreported fixes: 2; Closed: 5


Week 10: 2nd - 6th September

This week I spent a lot of time studying and developing a new utility for the bmesh module - 'BM_vert_splice_collapse'

I also dedicated myself to one of the mentorship program tasks (T68836)

New patches
  • D5663 Bmesh: New utility BM_vert_splice_collapse.
Commits
  • BT misc (general check, cleanup, assign & close work).
  • Transform: Split transform_conversions into multiple files (4e731ec97bd4).
  • Transform: Improve hierarchy in mixed snap edge detection (966c00060f8e).
Fixes

Fixed unreported: snapping to 3d tracking markers sometimes fails (08991c01f01c).

Fixed: 1; Unreported fixes: 1; Closed: 0


Week 9: 26th - 30th August

This week I focused on improving the automerge tool. The point now is make this tool intersects all edges.

The task is challenging because the bmesh module does not have a merge and collapse function for vertices pair.

And to make the new feature work correctly I have to redo the weld_verts operator.

New patches
  • D5635 Split all Edge x Edge intersections with AutoMerge & Split option.
  • D5608 Snapping and Constraints: Snapping on the intersection geometry with the axis constraint.
Commits
  • BT misc (general check, cleanup, assign & close work).
  • Edit Mesh: AutoMerge and Split: Improve detection of the best split face (b1079ec3f289).
  • Edit Mesh AutoMerge: Improve Split Edges & Faces option (e57b14feae9b).
  • Edit Mesh: New option "Split Edges & Faces" to "AutoMerge" (6b189d2bcf35).
Fixes
  • Fixed T69273: Rotate tool gizmo not showing incremental snapping tick marks (07b1a5e05c28).
  • Fixed possible endless loop in AutoMerge and Split (7aed8f69d14d).
  • Fixed specific case where a vertex is ignored in snapping (963a991a20de).
  • Fixed assert restricting allowed operation (8d03e0449302).
Fixed: 4; Unreported fixes: 3; Closed: 2


Week 8: 19th - 23rd August

After much talk with the developers, the decision to create a snapping solution using GPU (as it is done with selection) had to be postponed. This is partly because of the contracted term of three months. So this week was focused on solving the tasks defined in D5532.

New patches
  • D5435 Edit Mesh: AutoMerge with option Split Edges.
Commits
  • BT misc (general check, cleanup, assign & close work).
  • Snapping System: Improve drawing indicating Perpendicular snap (777ca2dcdb32).
  • Transform: New Snap Option: Edge Perpendicular (dd08d68df835).
  • Editor Transform: New Snap Option Middle (58341242bf6b).
  • View3D Grid: fix imperial grid drawing (4bf37bafc270).
Fixes
  • (This time I removed the bug fixes that were caused by me from the list.)
  • Fixed T68969: current value '0' matches no enum in 'ToolSettings', '(null)'… (a2443848646c).
  • Fixed T68911: "illegal recursive expansion of macro id" (899d2461bf84).
  • Fixed T61286: Viewport grid units not visible (859f2561c858).
Fixed: 7; Unreported fixes: 3; Closed: 9


Week 7: 12th - 16th August

I started a brach locally to use GPU for snapping. The initial result was positive, mainly for code cleaning and simplification. There is not much consensus among developers about using the GPU for snapping. I hope the final numbers can make clear the benefits. If not accepted, at least the selection code has been improved :)

Commits
  • BT misc (general check, assign & close work).
  • View3D: Circle Select optimization (52421e9ace74).
  • Cleanup: DRW manager: Move select_buffer.c utilities out of the selection… (44d95cbf9561).
  • Cleanup: rename BaseOffset to ObjectOffsets (b5f5f6e319b2).
  • DRW: New function DRW_culling_min_max_test (261a02fc596d).
  • Edit Mesh Selection: Refactor: Redraw idmap buffer at runtime with only objects… (4d320f43133b).
  • Cleanup: Remove redundant headers (f4faf6d8560d).
  • Cleanup: Silence C4115 warning (4aad77306155).
Fixes
  • Fixed T68547: Plane Constraint inaccuracy (bb1719ddb5d0).
  • Fixed T68684: Vertex snapping with median not working if the object is not at… (95a0144293b8).
  • Fixed check that validates a selection index (0f79c346c63f).
  • Fixed T68782: false occlusion in selecting vertices and edges with objects in any… (e69fb4402702).
Fixed: 3; Unreported fixes: 1; Closed: 6


Week 6: 5th - 9th August

This week I continued working on a local brach to improve selection system of edit meshes for later use in the snapping system. The proposed improvements are: - Check for updates in 3d view automatically. - Draw the selection id only from objects within the threshold.

New patches
  • D5435 Edit Mesh Selection: Optimization: Draw only objects within the rect.
Commits
  • BT misc (general check, assign & close work).
  • ED_view3D: Remove and replace ED_view3d_select_id_read (f9cf8151603d ).
  • New BLI Function: projmat_from_window_region (ad417f73c0dc).
  • Select utils refactor: remove lagacy ED_view3d_select_id_read_rect (9d7d34c12af5).
  • Edit Mesh Selection: Move ED_view3d_select_ functions to bf_draw (764cc75e1f92).
Fixes
  • Fixed unreported: Dopesheet transform regressions due to {GitCommit|81dc76c19cff} (3227b37141f4).
  • Fixed unreported: Face selection sometimes does not work in weight, paint and texture mode. (4e27bc2c981).
  • Fixed T67259 Auto depth not working with multires in sculpt mode (52f83011c8f0).
  • Fixed T68137 Dopesheet Editor: Moving keyframes by a number value doesn't work (dcbce4b92419).
  • Fixed T68320 measure tool memoryleak (467b0aa227d4).
Fixed: 5; Unreported fixes: 2; Closed: 6


Week 5: 29th July - 2nd August

I started working on a local branch to improve the selection system and possibly use it in the snapping system. Ideas: - Check for updates in 3d view automatically. - Draw the selection id only from objects within the threshold.

New patches
  • D5396 Fix T67259 : Auto depth not working with multires in sculpt mode
Commits
  • BT misc (general check, assign & close work).
  • DRW: Select Engine: Create DRWPass only when context requests it (5ba070ce53be).
  • Cleanup: clang format (cb1b7e8a4861).
  • DRW: Select Engine: Set uniform only once per ShadowGroup (8fbe18dc8dc3).
  • View3D Mesh Selection: Specify select_mode directly for Circle, Lasso and Box… (ae7137cdf862).
  • DRW: Select Engine: Add a utility to detect select_node (53a091663694).
  • Edit Mesh Select: Remove redundant and deprecated FAKE_SELECT_MODE_... (65b6d4a34dd8).
  • DRW: Select Engine: Use specified offset. (eff91da4dfb6).
  • DRW: Select Engine: remove unnecessary DRWShadingGroup creations (abebb2764481).
  • Cleanup: remove unnecessary include (49b2162309da).
  • Cleanup: remove unused member (421280a3f767).
  • DRW manager: select engine: create generic draw_select_id_mesh (af4dcc6073fa).
  • Cleanup: Rearrange Select Engine into multiple files (43ec8d7ae96f).
  • DRW manager: select engine: create generic draw_select_id_mesh (8586a2eae41b).
  • Cleanup: Rearrange Select Engine into multiple files (72092b7eba30).
  • DRW manager: select engine: remove redundant calls (fe47c7bf8435).
  • 3D View: Move selection API to a Selection engine. (651d8bfd98db).
Fixes
  • Fixed unreported: length measure displayed on the "Sequence Slide" operator panel (a897c8e342f4).
  • Fixed T63570 Proportional editing resets scaling along Y and Z axis on mouse… (81dc76c19cff).
  • Fixed unreported: Selection of mesh_cage element occluded by the mesh_cage itself. (c060a835bbcd).
  • Fixed T68055 mesh selection issues, once blend is loaded second time in a… (eb7fe7546c14).
  • Fixed T67951 Bone selection is broken on some Intel GPUs (d8fb63661b32).
  • Fixed T67597 Texture painting: Texture slots that correspond to nodes inside… (bc42092a7ddb).
Fixed: 4; Unreported fixes: 2; Closed: 4


Week 4: 22nd - 26th July

Focused on bug-fixes and tracker.

New patches
  • D5361 Fix T67460: Vertex painting: Sampling color opens empty options window in viewport
Commits
  • BT misc (general check, assign & close work).
  • WM: Pre-fill bug-reports for addons. (963b7611442c).
  • Fixed T67671 Blender crashes when resizing sidebar with a colorbamp (11b994e26e4d).
  • Fixed T67299 UV Stretching Overlay of type "Area" fail when any face is hidden (caaf12cdba65).
  • Fixed T67389 Transform constraints fail at large distances (6e72d3e00e4a).
Fixed: 3; Unreported fixes: 0; Closed: 12


Week 3: 15th - 19th July

I focused on bug-fixes and tracker.

New patches
  • D5277 Transform: Optimize edge slide
  • D5286 Fix T67140: Moving a pose bone doesnt update the bone's transform button props realtime.
  • D5291 Fix HEAP CORRUPTION DETECTED in Eevee + Attribute Node
  • D5303 WM: Pre-fill bug-reports for addons
  • D5308 Fix T67315: "Snap during transform" disabled after using "Move" and editing any value in the "redo last" panel.
  • D5314 Fix T67389: Problem when moving with constraint large distances.
Bug Tracker
  • BT misc (general check, assign & close work).
  • Fixed T59713 Armature layer dots not updated on changes. (709f126e8143).
  • Fixed T67115 Changing the Shape of a Force Field object does not refresh the animation. (526272bf7ca0).
  • Fixed T67001 Studio and Flat lightning in single color do not respect clipping region. (11741ff682f8).
Fixed: 3; Unreported fixes: 0; Closed: 10


Week 2: 8th - 12th July

This week I was mainly involved in triaging new reports and fixing bugs. Since the blender RC has been released, for security a few fixes have been delayed and are waiting for review (D5247, D5212 and D5049).

Bug Tracker
  • BT misc (general check, assign & close work).
  • Fixed T61401 Failure to register a GizmoGroup after unregistering it. (c1bcde0c0fea).
  • Fixed T66601 Redo Panels are empty the first time a workspace is active. (8d4800990ce1).
Fixed: 2; Unreported fixes: 0; Closed: 8


Week 1: 1st - 5th July

This week I was mainly involved in triaging new reports and fixing bugs.

I also had the first considerations with the main development team on Snapping & precision modeling improvements. T66337, T66484

Bug Tracker
  • BT misc (general check, assign & close work).
  • Investigated T65778 linked duplicate objects - issues with selection in edit mode.
  • Investigated T60689 Flip Active/Selected Bone does not work in weight paint mode.
  • Investigated T66316 "Open on Mouse Over" does not work in all menus.
  • Investigated T66313 Outliner - null pointer AV in unlink object callback (master branch).
  • Investigated T62101 Grease Pencil selection order is wrong.
  • Fixed T61360 Smooth Vertex Weights operator affects ALL objects that are in weight paint mode(even deselected ones) (12788538496a).
  • Fixed T66301 Crash on vertex slide when the vertex is not linked to a face. 3c6260d42de0.
  • Fixed T66340 Missing diaognal layer of particles with default cube and grid distribution (65bc59a56d0b).
  • Fixed (unreported) Transform Snap: Fix dependency cycle between transformed object and object with modifiers (7b93aebff942).
Code Review
  • accepted D5185 Fix T66433: skin resize (Ctrl+A) could crash.
  • accepted D5193 Proposed fix for T62101.
Fixed: 3; Unreported fixes: 1; Investigated: 5; Closed: 4