User:Manowii/Reports/2019

Week 7: 12th - 16th August

I started a brach locally to use GPU for snapping. The initial result was positive, mainly for code cleaning and simplification. There is not much consensus among developers about using the GPU for snapping. I hope the final numbers can make clear the benefits. If not accepted, at least the selection code has been improved :)

Commits
    • BT misc (general check, assign & close work).
    • View3D: Circle Select optimization (52421e9ace74).
    • Cleanup: DRW manager: Move select_buffer.c utilities out of the selection… (44d95cbf9561).
    • Cleanup: rename BaseOffset to ObjectOffsets (b5f5f6e319b2).
    • DRW: New function DRW_culling_min_max_test (261a02fc596d).
    • Edit Mesh Selection: Refactor: Redraw idmap buffer at runtime with only objects… (4d320f43133b).
    • Cleanup: Remove redundant headers (f4faf6d8560d).
    • Cleanup: Silence C4115 warning (4aad77306155).
Fixes
    • Fixed T68547: Plane Constraint inaccuracy (bb1719ddb5d0).
    • Fixed T68684: Vertex snapping with median not working if the object is not at… (95a0144293b8).
    • Fixed check that validates a selection index (0f79c346c63f).
    • Fixed T68782: false occlusion in selecting vertices and edges with objects in any… (e69fb4402702).
Fixed: 3; Unreported fixes: 1; Closed: 6

Week 6: 5th - 9th August

This week I continued working on a local brach to improve selection system of edit meshes for later use in the snapping system. The proposed improvements are: - Check for updates in 3d view automatically. - Draw the selection id only from objects within the threshold.

New patches
    • D5435 Edit Mesh Selection: Optimization: Draw only objects within the rect.
Commits
    • BT misc (general check, assign & close work).
    • ED_view3D: Remove and replace ED_view3d_select_id_read (f9cf8151603d ).
    • New BLI Function: projmat_from_window_region (ad417f73c0dc).
    • Select utils refactor: remove lagacy ED_view3d_select_id_read_rect (9d7d34c12af5).
    • Edit Mesh Selection: Move ED_view3d_select_ functions to bf_draw (764cc75e1f92).
Fixes
    • Fixed unreported: Dopesheet transform regressions due to {GitCommit|81dc76c19cff} (3227b37141f4).
    • Fixed unreported: Face selection sometimes does not work in weight, paint and texture mode. (4e27bc2c981).
    • Fixed T67259 Auto depth not working with multires in sculpt mode (52f83011c8f0).
    • Fixed T68137 Dopesheet Editor: Moving keyframes by a number value doesn't work (dcbce4b92419).
    • Fixed T68320 measure tool memoryleak (467b0aa227d4).
Fixed: 5; Unreported fixes: 2; Closed: 6


Week 5: 29th July - 2nd August

I started working on a local branch to improve the selection system and possibly use it in the snapping system. Ideas: - Check for updates in 3d view automatically. - Draw the selection id only from objects within the threshold.

New patches
    • D5396 Fix T67259 : Auto depth not working with multires in sculpt mode
Commits
    • BT misc (general check, assign & close work).
    • DRW: Select Engine: Create DRWPass only when context requests it (5ba070ce53be).
    • Cleanup: clang format (cb1b7e8a4861).
    • DRW: Select Engine: Set uniform only once per ShadowGroup (8fbe18dc8dc3).
    • View3D Mesh Selection: Specify select_mode directly for Circle, Lasso and Box… (ae7137cdf862).
    • DRW: Select Engine: Add a utility to detect select_node (53a091663694).
    • Edit Mesh Select: Remove redundant and deprecated FAKE_SELECT_MODE_... (65b6d4a34dd8).
    • DRW: Select Engine: Use specified offset. (eff91da4dfb6).
    • DRW: Select Engine: remove unnecessary DRWShadingGroup creations (abebb2764481).
    • Cleanup: remove unnecessary include (49b2162309da).
    • Cleanup: remove unused member (421280a3f767).
    • DRW manager: select engine: create generic draw_select_id_mesh (af4dcc6073fa).
    • Cleanup: Rearrange Select Engine into multiple files (43ec8d7ae96f).
    • DRW manager: select engine: create generic draw_select_id_mesh (8586a2eae41b).
    • Cleanup: Rearrange Select Engine into multiple files (72092b7eba30).
    • DRW manager: select engine: remove redundant calls (fe47c7bf8435).
    • 3D View: Move selection API to a Selection engine. (651d8bfd98db).
Fixes
    • Fixed unreported: length measure displayed on the "Sequence Slide" operator panel (a897c8e342f4).
    • Fixed T63570 Proportional editing resets scaling along Y and Z axis on mouse… (81dc76c19cff).
    • Fixed unreported: Selection of mesh_cage element occluded by the mesh_cage itself. (c060a835bbcd).
    • Fixed T68055 mesh selection issues, once blend is loaded second time in a… (eb7fe7546c14).
    • Fixed T67951 Bone selection is broken on some Intel GPUs (d8fb63661b32).
    • Fixed T67597 Texture painting: Texture slots that correspond to nodes inside… (bc42092a7ddb).
Fixed: 4; Unreported fixes: 2; Closed: 4


Week 4: 22nd - 26th July

Focused on bug-fixes and tracker.

New patches
    • D5361 Fix T67460: Vertex painting: Sampling color opens empty options window in viewport
Commits
    • BT misc (general check, assign & close work).
    • WM: Pre-fill bug-reports for addons. (963b7611442c).
    • Fixed T67671 Blender crashes when resizing sidebar with a colorbamp (11b994e26e4d).
    • Fixed T67299 UV Stretching Overlay of type "Area" fail when any face is hidden (caaf12cdba65).
    • Fixed T67389 Transform constraints fail at large distances (6e72d3e00e4a).
Fixed: 3; Unreported fixes: 0; Closed: 12


Week 3: 15th - 19th July

I focused on bug-fixes and tracker.

New patches
    • D5277 Transform: Optimize edge slide
    • D5286 Fix T67140: Moving a pose bone doesnt update the bone's transform button props realtime.
    • D5291 Fix HEAP CORRUPTION DETECTED in Eevee + Attribute Node
    • D5303 WM: Pre-fill bug-reports for addons
    • D5308 Fix T67315: "Snap during transform" disabled after using "Move" and editing any value in the "redo last" panel.
    • D5314 Fix T67389: Problem when moving with constraint large distances.
Bug Tracker
    • BT misc (general check, assign & close work).
    • Fixed T59713 Armature layer dots not updated on changes. (709f126e8143).
    • Fixed T67115 Changing the Shape of a Force Field object does not refresh the animation. (526272bf7ca0).
    • Fixed T67001 Studio and Flat lightning in single color do not respect clipping region. (11741ff682f8).
Fixed: 3; Unreported fixes: 0; Closed: 10


Week 2: 8th - 12th July

This week I was mainly involved in triaging new reports and fixing bugs. Since the blender RC has been released, for security a few fixes have been delayed and are waiting for review (D5247, D5212 and D5049).

Bug Tracker
    • BT misc (general check, assign & close work).
    • Fixed T61401 Failure to register a GizmoGroup after unregistering it. (c1bcde0c0fea).
    • Fixed T66601 Redo Panels are empty the first time a workspace is active. (8d4800990ce1).
Fixed: 2; Unreported fixes: 0; Closed: 8


Week 1: 1st - 5th July

This week I was mainly involved in triaging new reports and fixing bugs.

I also had the first considerations with the main development team on Snapping & precision modeling improvements. T66337, T66484

Bug Tracker
    • BT misc (general check, assign & close work).
    • Investigated T65778 linked duplicate objects - issues with selection in edit mode.
    • Investigated T60689 Flip Active/Selected Bone does not work in weight paint mode.
    • Investigated T66316 "Open on Mouse Over" does not work in all menus.
    • Investigated T66313 Outliner - null pointer AV in unlink object callback (master branch).
    • Investigated T62101 Grease Pencil selection order is wrong.
    • Fixed T61360 Smooth Vertex Weights operator affects ALL objects that are in weight paint mode(even deselected ones) (12788538496a).
    • Fixed T66301 Crash on vertex slide when the vertex is not linked to a face. 3c6260d42de0.
    • Fixed T66340 Missing diaognal layer of particles with default cube and grid distribution (65bc59a56d0b).
    • Fixed (unreported) Transform Snap: Fix dependency cycle between transformed object and object with modifiers (7b93aebff942).
Code Review
    • accepted D5185 Fix T66433: skin resize (Ctrl+A) could crash.
    • accepted D5193 Proposed fix for T62101.
Fixed: 3; Unreported fixes: 1; Investigated: 5; Closed: 4