User:ISS/Reports/2020

Week 1 (Jan 1 - Jan 3)

Whole week dedicated to triaging.

Triage:

  • Reviewed: 33
  • Confirmed: 10
  • Invalid: 2
  • Needs Information from User: 7
  • Resolved: 7

Code Review:

  • Fix T51828 VSE Proxy smaller than 100% produces wrong results when using Crop or Offset for movie strip D6314

Commits:

  • None

Week 2 (Jan 6 - Jan 11)

Whole week dedicated to triaging.

Triage:

  • Reviewed: 101
  • Confirmed: 16
  • Duplicate: 3
  • Invalid: 13
  • Needs Information from User: 42
  • Resolved: 11

Code Review:

  • None

Commits:

  • None

Week 3 (Jan 13 - Jan 18)

Whole week dedicated to triaging.

Involved in 131 reports:

  • Closed as Resolved (all): 6
  • Closed as Invalid (spam, feature requests, not-a-bug, 3rd-party-addon, no response): 56
  • Closed as Duplicate: 5
  • Confirmed (all): 32
  • Needs Info from User: 28
  • Needs Developer to Reproduce: 4
  • Own reported: 0

Review:

  • None Really

Own solutions in review: 5

  • Needs Review: Fix T70612: Crash on prefetching 3D preview scene strips D6117
  • Needs Review: Fix T69444: Scene strip won't play audio if duplicate uses camera. D6084
  • Needs Review: Fix T69921: VSE - Waveforms unnecessary redrawn on offset change D6053
  • Needs Review: VSE: Disk cache D5524
  • Needs Review: Sequencer: tool system integration D5460

Week 4 (Jan 20 - Jan 25)

Whole week dedicated to triaging and curfew classifying. Did few commits that were waiting for quite some time.

Involved in 134 reports:

  • Closed as Resolved (all): 12
  • Closed as Invalid (spam, feature requests, not-a-bug, 3rd-party-addon, no response): 39
  • Closed as Duplicate: 13
  • Confirmed (all): 30
  • Needs Info from User: 35
  • Needs Developer to Reproduce: 5
  • Own reported: 0

Review:

  • None Really

Own solutions in review: 3

  • Needs Review: Fix T70612: Crash on prefetching 3D preview scene strips D6117
  • Needs Review: Fix T69444: Scene strip won't play audio if duplicate uses camera. D6084
  • Needs Review: VSE: Disk cache D5524

Commits:


Week 5 (Jan 27 - Jan 31)

Whole week dedicated to triaging and curfew classifying. I did look into some issues during DoS attack, but all turned out to be a headscratcher, so I will need more time to continue working on them.

Involved in 88 reports:

  • Closed as Resolved (all): 4
  • Closed as Invalid (spam, feature requests, not-a-bug, 3rd-party-addon, no response): 29
  • Closed as Duplicate: 12
  • Confirmed (all): 20
  • Needs Info from User: 21
  • Needs Developer to Reproduce: 2
  • Own reported: 0

Review:

  • None Really

Own solutions in review: 3

  • Needs Review: Fix T70612: Crash on prefetching 3D preview scene strips D6117
  • Needs Review: Fix T69444: Scene strip won't play audio if duplicate uses camera. D6084
  • Needs Review: VSE: Disk cache D5524

Week 6 (Feb 3 - Feb 7)

Whole week dedicated to triaging and curfew classifying. During code quality day I did some cleanup and refactoring, which turned out into functional change (D6786)

Involved in 57 reports:

  • Closed as Resolved (all): 6
  • Closed as Invalid (spam, feature requests, not-a-bug, 3rd-party-addon, no response): 6
  • Closed as Duplicate: 5
  • Confirmed (all): 11
  • Needs Info from User: 26
  • Needs Developer to Reproduce: 3
  • Own reported: 0

Review:

  • None Really

Own solutions in review: 5

  • Needs Review: VSE: Remove atomized image duplication for preprocessing stage D6790
  • Needs Review: VSE: Refactor proxy loading D6786
  • Needs Review: Fix T70612: Crash on prefetching 3D preview scene strips D6117
  • Needs Review: Fix T69444: Scene strip won't play audio if duplicate uses camera. D6084
  • Needs Review: VSE: Disk cache D5524

Commits:

Week 7 (Feb 10 - Feb 14)

Whole week dedicated to triaging and curfew classifying. Involved in 45 reports:

  • Closed as Resolved (all): 13
  • Closed as Invalid (spam, feature requests, not-a-bug, 3rd-party-addon, no response): 5
  • Closed as Duplicate: 2
  • Confirmed (all): 13
  • Needs Info from User: 9
  • Needs Developer to Reproduce: 3
  • Own reported: 0

Review:

  • None Really

Own solutions in review: 7

  • Accepted: Fix T70229: Show Cache On will cause a lower fps D6835
  • Accepted: VSE: Remove atomized image duplication for preprocessing stage D6790
  • Accepted: Fix T70612: Crash on prefetching 3D preview scene strips D6117
  • Needs Review: VSE: Fix assigning effect strip inputs D6868
  • Needs Review: VSE: Refactor proxy loading D6786
  • Needs Review: Fix T69444: Scene strip won't play audio if duplicate uses camera. D6084
  • Needs Review: VSE: Disk cache D5524

Commits:

Week 8 (Feb 17 - Feb 21)

Whole week dedicated to triaging. Resumed works on Disk cache D5524

Involved in 31 reports:

  • Closed as Resolved (all): 3
  • Closed as Invalid (spam, feature requests, not-a-bug, 3rd-party-addon, no response): 1
  • Closed as Duplicate: 1
  • Confirmed (all): 21
  • Needs Info from User: 3
  • Needs Developer to Reproduce: 2
  • Own reported: 0

Review:

  • None Really

Own solutions in review: 6

  • Accepted: Fix T70612: Crash on prefetching 3D preview scene strips D6117
  • Needs Review: VSE: Refactor delete operator and API D6892
  • Needs Review: VSE: Fix assigning effect strip inputs D6868
  • Needs Review: Fix T69444: Scene strip won't play audio if duplicate uses camera. D6084
  • Needs Review: VSE: Disk cache D5524
  • Needs Revision: VSE: Refactor proxy loading D6786

Commits:

Week 9 (Feb 24 - Feb 28)

Done mostly triaging, Updated Disk cache patch D5524, which still needs some finishing touches. Next up will be some more tools for toolbar, I would like to add at least 4.

Involved in 41 reports:

  • Closed as Invalid (spam, feature requests, not-a-bug, 3rd-party-addon, no response): 14
  • Closed as Duplicate: 3
  • Confirmed (all): 18
  • Needs Info from User: 4
  • Needs Developer to Reproduce: 2
  • Own reported: 0

Review:

  • None Really

Own solutions in review: 6

  • Accepted: Fix T70612: Crash on prefetching 3D preview scene strips D6117
  • Needs Review: VSE: Refactor delete operator and API D6892
  • Needs Review: VSE: Fix assigning effect strip inputs D6868
  • Needs Review: Fix T69444: Scene strip won't play audio if duplicate uses camera. D6084
  • Needs Review: VSE: Disk cache D5524
  • Needs Revision: VSE: Refactor proxy loading D6786

Week 10 (Mar 2 - Mar 6)

This week, I have focused on finishing some patches I had in review (mainly disk cache and tools, so they can be added in 2.83) I have 3 new tools in review, split tools took most time to implement. I will need to consult 1 more tool if it shold be included, because of its experimental nature. Done some triaging as well, but not as much as usually, but I will return to mostly triaging now. In next week I expect to adress issues raised durin review process.

Involved in 35 reports:

  • Closed as Resolved (all): 0
  • Closed as Invalid (spam, feature requests, not-a-bug, 3rd-party-addon, no response): 14
  • Closed as Duplicate: 3
  • Confirmed (all): 15
  • Needs Info from User: 1
  • Needs Developer to Reproduce: 2
  • Own reported: 0

Review:

  • None Really

Own solutions in review: 9

  • Accepted: Fix T70612: Crash on prefetching 3D preview scene strips D6117
  • Needs Review: VSE: Add color picker tool D7064
  • Needs Review: VSE: Add slip tool D7063
  • Needs Review: Add Scissors tool and new Blade modes to VSE D7019
  • Needs Review: VSE: Refactor delete operator and API D6892
  • Needs Review: VSE: Fix assigning effect strip inputs D6868
  • Needs Review: VSE: Refactor proxy loading D6786
  • Needs Review: Fix T69444: Scene strip won't play audio if duplicate uses camera. D6084
  • Needs Review: VSE: Disk cache D5524

Commits:

  • Fix T74334: VSE can't import multiple movie files rB6fa4581d92ef
  • Fix T74320: Sound strip waveforms drawing allows negative volume values rBe9e4f6af9e79

Week 11 (Mar 09 - Mar 13)

This week I have done mostly triaging. Reviewed 1 patch and updated tool and disk cache patches Next week I will continue updating patches as needed, If there will be nothing to triage and nothing to work on as planned, I can look at some VSE bugs and fix them.

Involved in 36 reports:

  • Closed as Invalid (spam, feature requests, not-a-bug, 3rd-party-addon, no response): 13
  • Closed as Duplicate: 4
  • Confirmed (all): 14
  • Needs Info from User: 5

Review:

  • VSE: changes to the strips drawing D6883

Own solutions in review: 9

  • Needs Review: VSE: Add color picker tool D7064
  • Needs Review: VSE: Add slip tool D7063
  • Needs Review: Add Scissors tool and new Blade modes to VSE D7019
  • Needs Review: VSE: Refactor delete operator and API D6892
  • Needs Review: VSE: Fix assigning effect strip inputs D6868
  • Needs Review: VSE: Disk cache D5524
  • Needs Revision: VSE: Refactor proxy loading D6786

Week 12 (Mar 16 - Mar 20)

Done a bit less triaging then I should perhaps, I reviewed old unconfirmed reports, this is very slow and not very productive process, but I managed to close at least few old reports. Disk cache has been merged, with suggestion to look for different compression algorithms, that can do multithreaded encoding or decoding. That would solve issue with CPU bottleneck, though I think, that we will still need some write queue that would run from thread, so main thread is freed as soon as possible. So I will look into implementing this (not sure if next week). Strip drawing improvements is in as well, without drawing Fcurve overlay - will do review next week. Another review(at least initial) for next week will be D7198 - Automaticly build proxy

Plan for BCON2 overall is to fix ideally 1 bug per day along with triaging, reviews and other development.

Involved in 0 reports:

  • Closed as Resolved (all): 0
  • Closed as Invalid (spam, feature requests, not-a-bug, 3rd-party-addon, no response): 0
  • Closed as Duplicate: 0
  • Confirmed (all): 0
  • Needs Info from User: 0
  • Needs Developer to Reproduce: 0
  • Own reported: 0

Review:

  • VSE: changes to the strips drawing D6883
  • Check if actseq is NULL before dereferencing it in sequencer_select_grouped_exec D7170

Own solutions in review: 7

  • Needs Review: VSE: Add color picker tool D7064
  • Needs Review: VSE: Add slip tool D7063
  • Needs Review: VSE: Refactor delete operator and API D6892
  • Needs Review: VSE: Fix assigning effect strip inputs D6868
  • Needs Revision: VSE: Refactor proxy loading D6786

New:

  • Needs Review: Fix T74958: Infinite loop on using strip as modifier mask D7201

Commits:

Week 13 (Mar 23 - Mar 27)

This week I was involved in triaging as per usual. Little bit more review than I expected, in case of D7252 and D7248 quite a bit outside of area I am comfortable in. Worked on 4 bugfixes this week - close enough to what I ought to do.

Next week I should try to move with patches that I have in review. Some are there for quite some time. Continue with aim for at least 1 fix per day and triaging reports.

Involved in 50 reports:

Script I was using to generate these reports doesn't seem to work well. This time I used query https://developer.blender.org/feed/transactions/query/z5oqbo0I7PMi/#R to get number of reports I participated in. Will fix script for next time, I have built query that works fast, I just need to write some filters.

Review:

  • VSE: draw f-curves for opacity and volume values on the strips D7205
  • Fix T67499: Sequencer: Range > Set End Frame is set one frame too late. D7246
  • WIP: Automaticly build proxy when movie and image files are added D7198
  • Fix T73945: Don't grey out "Calculate to Frames" in some cases D7252
  • Fix T74111: Animation Playback Delayed With Time Remapping And AV-Sync D7248

Own solutions in review: 7

  • Needs Review: Fix T74897: VSE animation doesn't work D7264
  • Needs Review: Fix T74958: Infinite loop on using strip as modifier mask D7201
  • Needs Review: VSE: Add color picker tool D7064
  • Needs Review: VSE: Add slip tool D7063
  • Needs Review: VSE: Refactor delete operator and API D6892
  • Needs Review: VSE: Fix assigning effect strip inputs D6868
  • Needs Review: VSE: Refactor proxy loading D6786

Commits:

Week 14 (Mar 30 - Apr 03)

This week

  • I was involved in triaging as per usual.
  • Made 4 bugfixes and 2 cleanups for code quality day.
  • I have failed to get my patches reviewed - I haven't even tried.

Next week

  • Really move on with review, at least issues that have limited amount of time to be added (BCON2)
  • More triaging
  • I will probably have to prioritize working on tools, because it looks like I am not able to get to it done while doing bugfixing.

Involved in 50 reports:

  • Confirmed: 14
  • Closed as Resolved: 1
  • Closed as Invalid: 7
  • Closed as Duplicate: 2
  • Needs Info from User: 19
  • Needs Developer to Reproduce: 0
  • Actions total: 81

Review: 2

  • Fix T67499: Sequencer: Range > Set End Frame is set one frame too late.. D7246
  • WIP: Automaticly build proxy when movie and image files are added. D7198

Own solutions in review: 12

  • Accepted: Fix T74602: Sequencer slip operator ignores offset constraints D7288
  • Needs Review: Refactor sample operator D7315
  • Needs Review: Fix T74440: Blend Factor in Color Mix strips is broken D7314
  • Needs Review: Fix T74875: Preview shows previously cached frame after Hard Cut D7313
  • Needs Review: Fix T74603: Tweaking offsets causes strips to "reverse" D7285
  • Needs Review: Fix T74897: VSE animation doesn't work D7264
  • Needs Review: Fix T74958: Infinite loop on using strip as modifier mask D7201
  • Needs Review: VSE: Add color picker tool D7064
  • Needs Review: VSE: Add slip tool D7063
  • Needs Review: VSE: Refactor delete operator and API D6892
  • Needs Review: VSE: Fix assigning effect strip inputs D6868
  • Needs Review: VSE: Refactor proxy loading D6786

Commits:

  • VSE: don't allow strip preview when clicking on the scrubbing region rB0e7599bc15d8
  • Cleanup: Fix comment style and check if they are valid or make sense rB0d0036cb53f8
  • Cleanup: Use _fn as a suffix for callbacks in VSE code rB43cc2f319592