Process/Contributing Code/Review Playbook

= Blender Code Review Playbook =

This page describes various scenarios that can occur when reviewing code, and standardized responses. It is the code review counterpart of the Bug Triaging Playbook.

Description Lacking Information
Often patches only describe what they do, and not what problem they solve, why this is the best solution, how it fits into the bigger picture, what the impact is on users, etc.

Example:

This response should only be used when the patch itself does look useful. If that is not the case, it is likely that there is a bigger issue than just the patch description.

Mixing Formatting/Cleanup and Functional Changes
Functional (how Blender works) and non-functional (refactoring, reformatting, commenting) changes should be strictly separated. This response should only be used when the patch itself does look useful. If that is not the case, it is likely that there is a bigger issue than just a mix of functional and non-functional changes.

User feedback in development task
Users often get excited about a new feature / patch and post questions, feedback, examples etc. Design tasks and patches should focus on development though.