User:Manowii/Reports/2019

Week 27: 30th December - 3rd January
This week I organized my time between triaging and improvements in the Auto Merge & Split feature.

New patches
 * Fix T68878: Update shapekeys during transformation

Reviews
 * Reviewed Fix T72682: Regression when moving markers while holding ctrl.

Commits
 * Edit Mesh: Use multithreading in other parts of Auto Merge & Split.
 * BLI_kdopbvh: Deduplicate code.
 * BLI_bvhtree_overlap does not work multithreaded.
 * BLI_bvhtree_overlap: Don't use BLI_task API when not needed.
 * BLI_bvhtree_overlap: Make sure the number of nodes matches the number of threads.
 * Edit Mesh: Multithread support for Auto Merge & Split.
 * BLI_bvhtree_overlap: Improve non-multithreaded usage.
 * Manual: Amature Posing: Inform Relative Mirror limitation.
 * Transform: Pose: Partial support for Auto IK + X-Mirror.
 * EditMesh: Improve AutoMerge with Split Edges & Faces.
 * Transform: Individual Origins: Create islands between only selected uvs..

Fixes
 * BLI_bvhtree_overlap: Fix wrong count of child nodes.
 * Fixed T72792: Crash with Vertex Groups + Weld Modifier after generative modifiers.
 * Fixed T68131: Cycles bake panel code typo.


 * Fixed: 2; Unreported fixes: 1; Reviewed: 1; Closed: 30

Week 26: 23rd - 27th December
This week I spent most of the time with triage and bug fixes. I also explored the collision code for optimization a bit.

New patches
 * Fix T72524: Weight Painting not correctly affecting the projected vertices
 * Cloth: Small improvement in self collision
 * Transform: Move some hardcoded keyitems to the user keymap_data
 * Fix T72459: Some modifiers break vertex parent

Commits
 * Transform: Use parent bone orientation if the bone has not size.


 * Fixed: 0; Reviewed: 2; Closed: 27

Week 25: 16th - 20th December
This week I focused on triage and bug fixing.

Fixes
 * Fixed T71795: Unproject with high clipping range sometimes results in nans.
 * Fixed T72372: color picker is unreliable with large "clip end" values.
 * Fixed unreported: Crash when confirms GRAPH_OT_decimate.
 * Fixed T72507: Depth of bones missing for navigation.


 * Fixed: 4; Unreported fixes: 1; Reviewed: 0; Closed: 20

Week 24: 9th - 13rd December
Week focused on completing Weld modifier, but also paying attention to bug tracker.

Commits
 * Manual: Weld Modifier Documentation.
 * Modifier: New Weld Modifier.
 * BLI_bvhtree_overlap_ex: add 'max_interactions' parameter.

Fixes
 * Fixed T72412: Weld Modifier: Merged edges not displayed in wireframe.
 * Fixed T72380: New Weld Modifier is crashing when used after a Vertex Weight….
 * Fixed: 2; Unreported fixes: 0; Reviewed: 0; Closed: 12

Week 23: 2nd - 6th December
This week I distributed my time between bug triage and the Weld Modifier proposal (patch almost done).

Fixes
 * Fixed T72071: Crash on snap to edge.
 * Fixed T72076: Edit mode circle selection inconsistency with animation.
 * Fixed: 2; Unreported fixes: 0; Reviewed: 0; Closed: 10

Week 22: 25th - 29th November
As usual, I focused on bug triage. I also started working on an idea for the Weld Modifier (for evaluation)..

Fixes
 * Fixed T72024: Transform Snap: Alingn Rotation distorts object.
 * Fixed T71558: Hair particles: Brush effect not occluded by emitter geometry.
 * Fixed: 2; Unreported fixes: 0; Reviewed: 0; Closed: 29

Week 21: 18th - 22nd November
Week focused on bug triage (asking for more information, closing, assigning developers or fixing).

Fixes
 * Fixed T71273: Bad encoding of utf-8 for Text objects.
 * Fixed: 1; Unreported fixes: 0; Reviewed: 0; Closed: 15

Week 20: 11th - 15nd November
Week focused on bug triage (asking for more information, closing, assigning developers or fixing).

Fixes
 * Fixed T71436: proportional_edit_objects turns off when translating cursor in edit….
 * Fixed: 1; Unreported fixes: 0; Reviewed: 0; Closed: 6

Week 19: 4th - 8th November
Week focused on bug triage (asking for more information, closing, assigning developers or fixing).

New patches
 * Fix T71273: Bad encoding of utf-8 for Text objects

Fixes
 * Fixed T71436: proportional_edit_objects turns off when translating cursor in edit….
 * Fixed T69799: Glitches when moving object camera is locked to.
 * Fixed: 2; Unreported fixes: 0; Reviewed: 0; Closed: 13

Week 18: 28th October - 1st November
Week focused on bug triage (asking for more information, closing, assigning developers or fixing).

Commits
 * Documentation: Update the snapping menu images.
 * Windows: Replace deprecated SHGetFolderPathW.
 * Transform: Add option to exclude back facing geometry from snapping.
 * mesh_snap_utilities_line: Cleanup: Silence Warning.

Fixes
 * Fixed T71124: UV Editor – Proportional Editing Falloff misses some Options.
 * Fixed T50148: Header: Wrong rounding when moving frames.
 * Fixed: 2; Unreported fixes: 1; Reviewed: 0; Assigned to: 29; Closed: 8

Week 17: 21st - 25th October
Week focused on bug triage (asking for more information, closing, assigning developers or fixing).

New patches
 * Fix T50148: Wrong rounding when moving frames

Fixes
 * Fixed T71104: Addon: snap utilites line. Errors with some cuts.
 * Fixed: 1; Unreported fixes: 0; Reviewed: 0; Assigned to: 22; Closed: 16

Week 16: 14th - 18th October
Week focused on bug triage (asking for more information, closing, assigning developers or resolving).

New patches
 * Fix T70873: Pivot Center calculation ignores mirror elements

Fixes
 * Fixed T70899: Looptools circle fails when new plane created aligned to view.
 * Fixed T70386: Crash when snapping to edges in specific situations.
 * Fixed T70729: Multi-object edit UV not transform all meshes.
 * Fixed T70594: mathutils.geometry.tessellate_polygon flips triangles.
 * Fixed T70601: Lasso select not functioning correctly in Armature Edit Mode.
 * Fixed T70386: Crash when snapping to edges in specific situations.
 * Fixed: 6; Unreported fixes: 0; Reviewed: 0; Assigned to: 48; Closed: 14

Week 15: 7th - 11th October
This week was focused on bug triage (asking for more information, closing, assigning developers and resolving).

Reviews
 * Reviewed UI: Fix grid scale text not having shadows in the 3d view infos.

Fixes
 * Fixed T70729: Multi-object edit UV not transform all meshes.
 * Fixed T70594: mathutils.geometry.tessellate_polygon flips triangles.
 * Fixed T70601: Lasso select not functioning correctly in Armature Edit Mode.
 * Fixed T70508: Wrong snapping default in Node Editor.
 * Fixed: 4; Unreported fixes: 0; Reviewed: 0; Assigned to: 40; Closed: 11

Week 14: 30th September - 4th October
This week was focused on bug triage (asking for more information, closing, assigning developers and resolving).

New patches
 * Bring back the schematic view of the Rigid Body Shape Collision

Commits
 * BT misc (general check, cleanup, assign & close work).
 * GPU: Make sure workaround is supported.

Fixes
 * Fixed T70418: Text Underline stays Flat on TextCurve Extrude.
 * Fixed T70328: Crash when editing loopcuts with AutoMerge & Split option.
 * Fixed T70317: Equal clip range crashing in Hue Correct & RGB Curves Nodes.


 * Fixed: 3; Unreported fixes: 1; Reviewed: 0; Closed: 17

Week 13: 23rd - 27th September
This week was focused on bug triage (asking for more information, closing, assigning developers and resolving).

Reviews
 * Reviewed Fix T70126: Can't Snap To Vertex With Rigidbody.
 * Reviewed 3D cursor tool: improve rotation for Orientation set to 'Geometry'.

Commits
 * BT misc (general check, cleanup, assign & close work).
 * DRW: Deduplicate drw_draw_depth_loop functions.
 * GPU: AMD: Remove workaround that doesn't work.

Fixes
 * Fixed T69639: Bevel Info bar Width value not affected by Unit Scale.
 * Fixed T70109: Crash with the Data Transfer Modifier (with any 'Edge Data' option).
 * Fixed T69743: Armature display issues with Intel 5x0 GPU.


 * Fixed: 3; Unreported fixes: 0; Reviewed: 2; Closed: 10

Week 12: 16th - 20th September
This week was focused on triage and bug fixes.

New patches
 * Transform: Pose: Partial support for Auto IK + X-Mirror
 * Fix T69799: Glitches when moving object camera is locked to
 * Split transform.c in multiple files

Reviews
 * Reviewed Fix T70020: Sculpt mode transform tools fail with cursor orientation.
 * Reviewed Fix T70006: crash when transforming paint curve edit points in sculpt mode ).
 * Reviewed Fix T69804: Transform tools in sculpt mode fails with transformed objects.
 * Reviewed Fix T69752: Texture paint sampling colors always 'merged down'.
 * Reviewed UI: Snapping Popover Labels.

Commits
 * BT misc (general check, cleanup, assign & close work).
 * DRW: Deduplicate drw_draw_depth_loop functions.
 * GPU: AMD: Remove workaround that doesn't work.

Fixes
 * Fixed T70109: Crash with the Data Transfer Modifier (with any 'Edge Data' option).
 * Fixed T67174: Weight paint gradient has empty redo panel.
 * Fixed T69855: 3DView glitches involving depth buffer.
 * Fixed T69853: Object orientation is wrong with some AMD deprecated drivers.
 * Fixed T69716: Can't select geometry hidden by faces created by modifiers.


 * Fixed: 5; Unreported fixes: 0; Reviewed: 5; Closed: 6

Week 11: 9th - 13rd September
This week I focused on implementing the new `BM_mesh_intersect_edges` tool, triaging and fixing bugs


 * New/Updated patches
 * Allow navigating while transforming.


 * Commits
 * BT misc (general check, cleanup, assign & close work).
 * Reviewed Fix T69037: Automerge is greyed-out in popover.
 * Transform: AutoMerge & Split: Create and merge vertices at edge intersections.
 * BMesh: New tool `BM_mesh_intersect_edges`.
 * BLIKdopBVH: New `BLI_bvhtree_overlap_ex` utility.
 * Transform: Split transform_conversions into multiple files..
 * Transform: Edit Mesh: Support mirror on all axes.


 * Fixes
 * Fixed T69792: Auto-merge split faces creates faces with unrelated wire edges..
 * Fixed T69382: Crash - Regression - GPU Intel HD 4000.
 * Fixed unreported: snapping to 3d tracking markers sometimes fails.
 * Fixed T69458: Edit Mesh selection bug from camera view.
 * Transform: Snap: Fix mixed snap without edge.


 * Fixed: 5; Unreported fixes: 2; Closed: 5

Week 10: 2nd - 6th September
This week I spent a lot of time studying and developing a new utility for the bmesh module - 'BM_vert_splice_collapse'

I also dedicated myself to one of the mentorship program tasks


 * New patches
 * Bmesh: New utility `BM_vert_splice_collapse`.


 * Commits
 * BT misc (general check, cleanup, assign & close work).
 * Transform: Split transform_conversions into multiple files.
 * Transform: Improve hierarchy in mixed snap edge detection.

Fixed unreported: snapping to 3d tracking markers sometimes fails.
 * Fixes


 * Fixed: 1; Unreported fixes: 1; Closed: 0

Week 9: 26th - 30th August
This week I focused on improving the automerge tool. The point now is make this tool intersects all edges.

The task is challenging because the bmesh module does not have a merge and collapse function for vertices pair.

And to make the new feature work correctly I have to redo the weld_verts operator.


 * New patches
 * Split all Edge x Edge intersections with AutoMerge & Split option.
 * Snapping and Constraints: Snapping on the intersection geometry with the axis constraint.


 * Commits
 * BT misc (general check, cleanup, assign & close work).
 * Edit Mesh: AutoMerge and Split: Improve detection of the best split face.
 * Edit Mesh AutoMerge: Improve `Split Edges & Faces` option.
 * Edit Mesh: New option "Split Edges & Faces" to "AutoMerge".


 * Fixes
 * Fixed T69273: Rotate tool gizmo not showing incremental snapping tick marks.
 * Fixed possible endless loop in AutoMerge and Split.
 * Fixed specific case where a vertex is ignored in snapping.
 * Fixed assert restricting allowed operation.


 * Fixed: 4; Unreported fixes: 3; Closed: 2

Week 8: 19th - 23rd August
After much talk with the developers, the decision to create a snapping solution using GPU (as it is done with selection) had to be postponed. This is partly because of the contracted term of three months. So this week was focused on solving the tasks defined in.


 * New patches
 * Edit Mesh: `AutoMerge` with option `Split Edges`.


 * Commits
 * BT misc (general check, cleanup, assign & close work).
 * Snapping System: Improve drawing indicating `Perpendicular` snap.
 * Transform: New Snap Option: Edge Perpendicular.
 * Editor Transform: New Snap Option Middle.
 * View3D Grid: fix imperial grid drawing.


 * Fixes
 * (This time I removed the bug fixes that were caused by me from the list.)
 * Fixed T68969: current value '0' matches no enum in 'ToolSettings', '(null)'….
 * Fixed T68911: "illegal recursive expansion of macro id".
 * Fixed T61286: Viewport grid units not visible.


 * Fixed: 7; Unreported fixes: 3; Closed: 9

Week 7: 12th - 16th August
I started a brach locally to use GPU for snapping. The initial result was positive, mainly for code cleaning and simplification. There is not much consensus among developers about using the GPU for snapping. I hope the final numbers can make clear the benefits. If not accepted, at least the selection code has been improved :)


 * Commits
 * BT misc (general check, assign & close work).
 * View3D: Circle Select optimization.
 * Cleanup: DRW manager: Move `select_buffer.c` utilities out of the selection….
 * Cleanup: rename `BaseOffset` to `ObjectOffsets`.
 * DRW: New function DRW_culling_min_max_test.
 * Edit Mesh Selection: Refactor: Redraw idmap buffer at runtime with only objects….
 * Cleanup: Remove redundant headers.
 * Cleanup: Silence C4115 warning.


 * Fixes
 * Fixed T68547: Plane Constraint inaccuracy.
 * Fixed T68684: Vertex snapping with median not working if the object is not at….
 * Fixed check that validates a selection index.
 * Fixed T68782: false occlusion in selecting vertices and edges with objects in any….


 * Fixed: 3; Unreported fixes: 1; Closed: 6

Week 6: 5th - 9th August
This week I continued working on a local brach to improve selection system of edit meshes for later use in the snapping system. The proposed improvements are: - Check for updates in 3d view automatically. - Draw the selection id only from objects within the threshold.


 * New patches
 * Edit Mesh Selection: Optimization: Draw only objects within the rect.


 * Commits
 * BT misc (general check, assign & close work).
 * ED_view3D: Remove and replace `ED_view3d_select_id_read`.
 * New BLI Function: projmat_from_window_region.
 * Select utils refactor: remove lagacy `ED_view3d_select_id_read_rect`.
 * Edit Mesh Selection: Move ED_view3d_select_ functions to bf_draw.


 * Fixes
 * Fixed unreported: Dopesheet transform regressions due to {GitCommit|81dc76c19cff}.
 * Fixed unreported: Face selection sometimes does not work in weight, paint and texture mode..
 * Fixed Auto depth not working with multires in sculpt mode.
 * Fixed Dopesheet Editor: Moving keyframes by a number value doesn't work.
 * Fixed measure tool memoryleak.


 * Fixed: 5; Unreported fixes: 2; Closed: 6

Week 5: 29th July - 2nd August
I started working on a local branch to improve the selection system and possibly use it in the snapping system. Ideas: - Check for updates in 3d view automatically. - Draw the selection id only from objects within the threshold.


 * New patches
 * Fix T67259 : Auto depth not working with multires in sculpt mode


 * Commits
 * BT misc (general check, assign & close work).
 * DRW: Select Engine: Create DRWPass only when context requests it.
 * Cleanup: clang format.
 * DRW: Select Engine: Set uniform only once per ShadowGroup.
 * View3D Mesh Selection: Specify select_mode directly for Circle, Lasso and Box….
 * DRW: Select Engine: Add a utility to detect `select_node`.
 * Edit Mesh Select: Remove redundant and deprecated `FAKE_SELECT_MODE_...`.
 * DRW: Select Engine: Use specified offset..
 * DRW: Select Engine: remove unnecessary DRWShadingGroup creations.
 * Cleanup: remove unnecessary include.
 * Cleanup: remove unused member.
 * DRW manager: select engine: create generic draw_select_id_mesh.
 * Cleanup: Rearrange Select Engine into multiple files.
 * DRW manager: select engine: create generic draw_select_id_mesh.
 * Cleanup: Rearrange Select Engine into multiple files.
 * DRW manager: select engine: remove redundant calls.
 * 3D View: Move selection API to a Selection engine..


 * Fixes
 * Fixed unreported: length measure displayed on the "Sequence Slide" operator panel.
 * Fixed Proportional editing resets scaling along Y and Z axis on mouse….
 * Fixed unreported: Selection of mesh_cage element occluded by the mesh_cage itself..
 * Fixed mesh selection issues, once blend is loaded second time in a….
 * Fixed Bone selection is broken on some Intel GPUs.
 * Fixed Texture painting: Texture slots that correspond to nodes inside….


 * Fixed: 4; Unreported fixes: 2; Closed: 4

Week 4: 22nd - 26th July
Focused on bug-fixes and tracker.


 * New patches
 * Fix T67460: Vertex painting: Sampling color opens empty options window in viewport


 * Commits
 * BT misc (general check, assign & close work).
 * WM: Pre-fill bug-reports for addons..
 * Fixed Blender crashes when resizing sidebar with a colorbamp.
 * Fixed UV Stretching Overlay of type "Area" fail when any face is hidden.
 * Fixed Transform constraints fail at large distances.


 * Fixed: 3; Unreported fixes: 0; Closed: 12

Week 3: 15th - 19th July
I focused on bug-fixes and tracker.


 * New patches
 * Transform: Optimize edge slide
 * Fix T67140: Moving a pose bone doesnt update the bone's transform button props realtime.
 * Fix HEAP CORRUPTION DETECTED in Eevee + Attribute Node
 * WM: Pre-fill bug-reports for addons
 * Fix T67315: "Snap during transform" disabled after using "Move" and editing any value in the "redo last" panel.
 * Fix T67389: Problem when moving with constraint large distances.


 * Bug Tracker
 * BT misc (general check, assign & close work).
 * Fixed Armature layer dots not updated on changes..
 * Fixed Changing the Shape of a Force Field object does not refresh the animation..
 * Fixed Studio and Flat lightning in single color do not respect clipping region..


 * Fixed: 3; Unreported fixes: 0; Closed: 10

Week 2: 8th - 12th July
This week I was mainly involved in triaging new reports and fixing bugs. Since the blender RC has been released, for security a few fixes have been delayed and are waiting for review (, and ).


 * Bug Tracker
 * BT misc (general check, assign & close work).
 * Fixed Failure to register a `GizmoGroup` after unregistering it..
 * Fixed Redo Panels are empty the first time a workspace is active..


 * Fixed: 2; Unreported fixes: 0; Closed: 8

Week 1: 1st - 5th July
This week I was mainly involved in triaging new reports and fixing bugs.

I also had the first considerations with the main development team on `Snapping & precision modeling improvements`. ,


 * Bug Tracker
 * BT misc (general check, assign & close work).
 * Investigated linked duplicate objects - issues with selection in edit mode.
 * Investigated Flip Active/Selected Bone does not work in weight paint mode.
 * Investigated "Open on Mouse Over" does not work in all menus.
 * Investigated Outliner - null pointer AV in unlink object callback (master branch).
 * Investigated Grease Pencil selection order is wrong.
 * Fixed Smooth Vertex Weights operator affects ALL objects that are in weight paint mode(even deselected ones).
 * Fixed Crash on vertex slide when the vertex is not linked to a face..
 * Fixed Missing diaognal layer of particles with default cube and grid distribution.
 * Fixed (unreported) Transform Snap: Fix dependency cycle between transformed object and object with modifiers.


 * Code Review
 * accepted Fix T66433: skin resize (Ctrl+A) could crash.
 * accepted Proposed fix for T62101.


 * Fixed: 3; Unreported fixes: 1; Investigated: 5; Closed: 4